Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[blockly] Add Quantity support to round block #2000

Merged
merged 2 commits into from
Aug 6, 2023
Merged

[blockly] Add Quantity support to round block #2000

merged 2 commits into from
Aug 6, 2023

Conversation

stefan-hoehn
Copy link
Contributor

@stefan-hoehn stefan-hoehn commented Aug 2, 2023 •
edited by florian-h05
Loading

Round block now also takes a Qty block as input.
Output type changes according to input.

image

@stefan-hoehn
[blockly] Add Quantity support to round block
57077f5 
Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
@stefan-hoehn stefan-hoehn requested a review from a team as a code owner August 2, 2023 16:45
@relativeci
Copy link

relativeci bot commented Aug 2, 2023 •
edited
Loading

Job #1101: Bundle Size — 15.75MiB (-0.03%).

8f1d239(current) vs 5397ca4 main#1100(baseline)

⚠️ Bundle contains 16 duplicate packages

Metrics (1 change)
                 Current
Job #1101		      Baseline
Job #1100
Initial JS 1.67MiB 1.67MiB
Initial CSS 608.89KiB 608.89KiB
Cache Invalidation 93.95% 93.94%
Chunks 219 219
Assets 689 689
Modules 1700 1700
Duplicate Modules 90 90
Duplicate Code 1.95% 1.95%
Packages 138 138
Duplicate Packages 15 15
Total size by type (2 changes)
                 Current
Job #1101		      Baseline
Job #1100
CSS 859.34KiB 859.34KiB
Fonts 526.1KiB 526.1KiB
HTML 1.23KiB 1.23KiB
IMG 140.74KiB 140.74KiB
JS 9.25MiB (-0.03%) 9.25MiB
Media 295.6KiB 295.6KiB
Other 4.72MiB (-0.02%) 4.72MiB

View job #1101 report View main branch activity

@rkoshak rkoshak mentioned this pull request Aug 2, 2023
Closed
@florian-h05
Minor code improvement
03abcd0 
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
florian-h05
florian-h05 approved these changes Aug 6, 2023
View reviewed changes
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Aug 6, 2023
@florian-h05 florian-h05 added this to the 4.1 milestone Aug 6, 2023
@florian-h05 florian-h05 merged commit ffb4ce6 into openhab:main Aug 6, 2023
@florian-h05 florian-h05 deleted the blockly_round_quantity branch August 6, 2023 17:08
@stefan-hoehn stefan-hoehn mentioned this pull request Jan 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florian-h05 florian-h05 florian-h05 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@stefan-hoehn @florian-h05