Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[webaudio] Allow stopping play #2031

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Conversation

dalgwen
Copy link
Contributor

@dalgwen dalgwen commented Aug 20, 2023

Use of a dictionary to store audio sources currently playing and stop them all when asked to.
Refs openhab/openhab-core#3766.

Signed-off-by: Gwendal Roulleau gwendal.roulleau@gmail.com

@dalgwen dalgwen requested a review from a team as a code owner August 20, 2023 10:54
@relativeci
Copy link

relativeci bot commented Aug 20, 2023

Job #1240: Bundle Size — 15.75MiB (-0.08%).

954355d(current) vs b7270d2 main#1158(baseline)

Important

Bundle introduced 1 and removed 1 duplicate package – View changed duplicate packages

Warning

Bundle introduced 13 new packages: @jsep-plugin/regex, @jsep-plugin/arrow, @jsep-plugin/object and 10 more – View changed packages

Bundle metrics  Change 10 changes Regression 5 regressions Improvement 1 improvement
                 Current
Job #1240
     Baseline
Job #1158
Regression  Initial JS 1.85MiB(+11.06%) 1.67MiB
Regression  Initial CSS 609.06KiB(+0.03%) 608.89KiB
Change  Cache Invalidation 93.81% 93.95%
Change  Chunks 217(-0.91%) 219
Change  Assets 683(-0.87%) 689
Change  Modules 2987(+75.71%) 1700
Regression  Duplicate Modules 173(+92.22%) 90
Improvement  Duplicate Code 1.61%(-17.44%) 1.95%
Regression  Packages 152(+10.14%) 138
Regression  Duplicate Packages 16(+6.67%) 15
Bundle size by type  Change 3 changes Regression 2 regressions Improvement 1 improvement
                 Current
Job #1240
     Baseline
Job #1158
Improvement  JS 9.24MiB (-0.15%) 9.25MiB
Regression  Other 4.73MiB (~+0.01%) 4.73MiB
Regression  CSS 860.29KiB (+0.09%) 859.49KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.23KiB 1.23KiB

View job #1240 reportView dalgwen:webaudio_stop branch activity

Use of a dictionary to store audio sources currently playing and stop them all when asked to. A corresponding core (webaudio sink) modification is following.
Signed-off-by: Gwendal Roulleau <gwendal.roulleau@gmail.com>
@florian-h05 florian-h05 removed the awaiting other PR Depends on another PR label Nov 4, 2023
@dalgwen
Copy link
Contributor Author

dalgwen commented Nov 4, 2023

Thanks @florian-h05 for removing the "awaiting other PR" tag, as the core pull request was indeed merged.

I rebased the code (as the "play" part moves to another file), and it is now ready for review.

Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@florian-h05 florian-h05 merged commit a2f9003 into openhab:main Nov 8, 2023
5 checks passed
@florian-h05 florian-h05 added this to the 4.1 milestone Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants