-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[blockly] Fix timer remove regression #2032
Conversation
Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
Job #1116: Bundle Size — 15.75MiB (~-0.01%).Metrics (1 change)
Total size by type (2 changes)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
I’ve just had a look a the Nashorn code, there it also does not remove the timer from this
.
@kaikreuzer Can you please cherry pick this to 4.0.x before the release is done? I’ve mentioned it in the release thread, seems like you didn’t see it. |
Fixes #2002. Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
I indeed didn't see the message and so this unfortunately hasn't yet been backported before the 4.0.3 build. I did so now, so that it will end up in 4.0.4. |
I usually backport when merging, but I was away (on vacation) and only had my phone with me, I merged with GitHub web but I cannot backport from my phone. Thanks for doing it anyway. |
Fixes openhab#2002. Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
Fixes #2002.