Add routes for home page tabs #2074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
ghys
approved these changes
Sep 18, 2023
There was a problem hiding this comment.
That's great! The much-requested feature I was referring to was #866 - have a way to show the locations tab for those who don't configure an overview page.
While it doesn't address the issue completely it's a good step forward as they could just open /locations if they want.
If we choose not to have a setting to configure the default initial tab, changing the tab would set a openhab.ui:home.lastHomePageTab local storage setting so the last accessed tab would be restored if they hit the root URL - this PR has made it easier.
In any case it's a nice improvement as it is.
JustinGeorgi
pushed a commit
to JustinGeorgi/openhab-webui
that referenced
this pull request
Sep 24, 2023
Adds routes for `/overview`, `/locations`, `/equipment` and `/properties` so a home page reload keeps the tab and routing to individual tabs is possible. --------- Signed-off-by: Florian Hotze <florianh_dev@icloud.com> Signed-off-by: jgeorgi <justin.georgi@gmail.com>
JustinGeorgi
pushed a commit
to JustinGeorgi/openhab-webui
that referenced
this pull request
Sep 24, 2023
Adds routes for `/overview`, `/locations`, `/equipment` and `/properties` so a home page reload keeps the tab and routing to individual tabs is possible. --------- Signed-off-by: Florian Hotze <florianh_dev@icloud.com> Signed-off-by: jgeorgi <justin.georgi@gmail.com>
digitaldan
pushed a commit
to digitaldan/openhab-webui
that referenced
this pull request
Sep 24, 2023
Adds routes for `/overview`, `/locations`, `/equipment` and `/properties` so a home page reload keeps the tab and routing to individual tabs is possible. --------- Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
florian-h05
added a commit
to florian-h05/openhab-webui
that referenced
this pull request
Dec 10, 2023
Fixes openhab#2196. Reverts openhab#2074. I have tried messing around with the browser history manually to fix that issue, however trying several approaches, none worked perfect. This is the best solution I could come up with, it at least remembers which tab you had opened when you navigate back to the home page from any other page. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds routes for
/overview,/locations,/equipmentand/propertiesso a home page reload keeps the tab and routing to individual tabs is possible.