Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix oh- components cannot be configured in action modals #2094

Merged
merged 2 commits into from
Sep 30, 2023

Conversation

florian-h05
Copy link
Contributor

@florian-h05 florian-h05 commented Sep 26, 2023

Fixes #927.

When attempting to open an oh- Vue component, e.g. oh-colorpicker-card, as action modal, it was not possible to configure it, even though actionModalConfig was set.
This was because oh- componens take their configuration from the computed config of the widget-mixin instead of the Vue component props.
This PR fixes that by using the actionModalConfig for the computed config of oh- components in action modals.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Fixes openhab#927.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 requested a review from a team as a code owner September 26, 2023 17:45
@florian-h05
Copy link
Contributor Author

@ghys I have battle-tested this on my production system and I haven't noticed any regressions, so this should be safe to merge.

@relativeci
Copy link

relativeci bot commented Sep 26, 2023

Job #1159: Bundle Size — 15.78MiB (+0.11%).

208def7(current) vs b7270d2 main#1158(baseline)

⚠️ Bundle contains 16 duplicate packages
⚠️ Bundle introduced 13 new packages: @jsep-plugin/regex, @jsep-plugin/arrow, @jsep-plugin/object and 10 more

Metrics (6 changes)
                 Current
Job #1159
     Baseline
Job #1158
Initial JS 1.67MiB(+0.19%) 1.67MiB
Initial CSS 608.89KiB 608.89KiB
Cache Invalidation 93.95% 93.95%
Chunks 219 219
Assets 689 689
Modules 2980(+75.29%) 1700
Duplicate Modules 170(+88.89%) 90
Duplicate Code 1.62%(-16.92%) 1.95%
Packages 152(+10.14%) 138
Duplicate Packages 16(+6.67%) 15
Total size by type (3 changes)
                 Current
Job #1159
     Baseline
Job #1158
CSS 859.97KiB (+0.06%) 859.49KiB
Fonts 526.1KiB 526.1KiB
HTML 1.23KiB 1.23KiB
IMG 140.74KiB 140.74KiB
JS 9.27MiB (+0.12%) 9.25MiB
Media 295.6KiB 295.6KiB
Other 4.73MiB (+0.11%) 4.73MiB

View job #1159 reportView florian-h05:actionmodal-oh-confi... branch activity

@florian-h05 florian-h05 added bug Something isn't working main ui Main UI labels Sep 26, 2023
Copy link
Member

@ghys ghys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't say I have battle-tested this myself but upon reading the code it makes sense!

LGTM

@ghys ghys added this to the 4.1 milestone Sep 30, 2023
@ghys ghys merged commit f32ef1f into openhab:main Sep 30, 2023
5 checks passed
@florian-h05 florian-h05 deleted the actionmodal-oh-config branch September 30, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opening popover/popup/sheet doesn't work from oh-list-item (listButton)
2 participants