Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BasicUI] Hide header row if label not explicitly set #2112

Merged
merged 1 commit into from
Oct 8, 2023

Conversation

lolodomo
Copy link
Contributor

@lolodomo lolodomo commented Oct 6, 2023

Applied to Chart/Image/Viodeo/Mapview/Webview elements.

Chart and Image elements are also now clickable.
Clicking allows toggling between header row shown and header row hidden.

Fix #2065

@lolodomo lolodomo added enhancement New feature or request basic ui Basic UI labels Oct 6, 2023
@lolodomo lolodomo requested a review from a team as a code owner October 6, 2023 18:29
Applied to Chart/Image/Viodeo/Mapview/Webview elements.

Chart and Image elements are also now clickable.
Clicking allows toggling between header row shown and header row hidden.

Fix openhab#2065

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo lolodomo force-pushed the basicui_toggle_header_line branch from b777267 to 7fa8189 Compare October 6, 2023 18:32
@lolodomo lolodomo changed the title [BasicUI] Hide header row if not label explicitly set [BasicUI] Hide header row if label not explicitly set Oct 6, 2023
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kaikreuzer kaikreuzer merged commit 1c362cc into openhab:main Oct 8, 2023
2 checks passed
@kaikreuzer kaikreuzer added this to the 4.1 milestone Oct 8, 2023
@lolodomo lolodomo deleted the basicui_toggle_header_line branch October 8, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
basic ui Basic UI enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Basic UI] Improve layout of header and buttons
2 participants