-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rules list: Add filtering by (multiple) tags #2122
Conversation
Job #1265: Bundle Size — 15.81MiB (+0.29%).Important Bundle introduced 1 and removed 1 duplicate package – View changed duplicate packages Warning Bundle introduced 13 new packages: @jsep-plugin/regex, @jsep-plugin/arrow, @jsep-plugin/object and 10 more – View changed packages Bundle metrics
Bundle size by type
View job #1265 report View d51x:rules_group_by_semantic branch activity |
Signed-off-by: Dmitry P. (d51x) <dimonich110@gmail.com>
Signed-off-by: Dmitry P. (d51x) <dimonich110@gmail.com>
Signed-off-by: Dmitry P. (d51x) <dimonich110@gmail.com>
Signed-off-by: Dmitry P. (d51x) <dimonich110@gmail.com>
Signed-off-by: Dmitry P. (d51x) <dimonich110@gmail.com>
Signed-off-by: Dmitry P. (d51x) <dimonich110@gmail.com>
Signed-off-by: Dmitry P. (d51x) <dimonich110@gmail.com>
Signed-off-by: Dmitry P. (d51x) <dimonich110@gmail.com>
Signed-off-by: Dmitry P. (d51x) <dimonich110@gmail.com>
Signed-off-by: Dmitry P. (d51x) <dimonich110@gmail.com>
Signed-off-by: Dmitry P. (d51x) <dimonich110@gmail.com>
738e28b
to
9110877
Compare
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
9110877
to
ee8800b
Compare
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! Nice contribution.
To save me some time, I decided to implent my review:
- I removed sort by semantics (as I want to generally remove semantics for rules) and sort by tags (as this is type of duplicated functionality of the tag filter).
- For the tag filter, I cleaned-up and refactored the code a bit, and removed the capitalization of the tags.
- I added a "Reset filter" functionality for convenience. I don't want to unselect all tags by hand ;-)
- I wrapped the tag filter inside an accordion, so the filter does not need much space by default, when you need it, just open the accordion.
BTW I can imagine having this capability implemented for pages and Items as well. In that case, the filtering should be refactored into a mixin and Vue component to avoid code duplication.
Follow-up for #2122. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Closes #2123.
This adds filtering by tags to the rules list, the filter is inside an accordion.
In case you select multiple tags, the filter behaves like OR, which means all rules which have at least one of the selected tags are displayed.
In case you use the searchbar, the rules list will be narrowed down to the rules which match the search query and have the selected tags.