Create aux badge for humidity setpoints similar to temperature badge #2154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the temperature badge shows both the measured temperature and the temperature setpoint in the form "measurement_value (setpoint_value)", e.g. 20° (21°). The proposed change introduces the same format for humidity badge by showing humidity setpoint in addition to humidity measurement. Signed-off-by: alexxys <alexxys@gmail.com>
|
@alexxys Can you please comment on this PR with a valid sign-off? You need to use your real name for sign off (sorry), see https://www.openhab.org/docs/developer/contributing.html#sign-your-work. |
Job #1229: Bundle Size — 15.8MiB (+0.22%).Warning Bundle contains 16 duplicate packages – View duplicate packages Warning Bundle introduced 13 new packages: @jsep-plugin/regex, @jsep-plugin/arrow, @jsep-plugin/object and 10 more – View changed packages Bundle metrics
  
Bundle size by type
|
|
@florian-h05, I updated the very first comment above. I hope it's enough? |
|
Yes, that’s fine. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the temperature badge shows both the measured temperature and the temperature setpoint in the form "measurement_value (setpoint_value)", e.g. 20° (21°). The proposed change introduces the same format for humidity badge by showing humidity setpoint in addition to humidity measurement.
Signed-off-by: Alexander Antonov alexxys@gmail.com