Items list: Fix searchbar broken after Items list update & Fix search query not stored #2184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes openhab#1334. Fixes openhab#1702. After editing or removing an Item, the searchbar of the Items list was not working anymore. Console showed this error: `TypeError: undefined is not an object (evaluating 'n.virtualList.params')` It seems that this was caused because the replaceAllItems operation was applied on the virtual list, but the was searchbar not re-rendered afterward. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
…enter Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
florian-h05
changed the title
florian-h05
changed the title
florian-h05
changed the title
Job #1289: Bundle Size — 15.82MiB (+0.34%).Important Bundle introduced 1 and removed 1 duplicate package – View changed duplicate packages Warning Bundle introduced 13 new packages: @jsep-plugin/regex, @jsep-plugin/arrow, @jsep-plugin/object and 10 more – View changed packages Bundle metrics
  
Bundle size by type
View job #1289 report View florian-h05:items-list-searchbar branch activity |
|
/cc @J-N-K |
florian-h05
added
enhancement
|
I can confirm this fixes the issue. |
|
Great! @ghys Can you please review this PR? |
stefan-hoehn
approved these changes
Dec 5, 2023
ghys
approved these changes
Dec 5, 2023
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
|
@ghys I addressed your review regarding the Vuex store, so this should be ready for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1334.
Fixes #1702.
After editing or removing an Item, the searchbar of the Items list was sometimes not working anymore. Console then showed this error:
It seems that this was caused because the replaceAllItems operation was applied on the virtual list without re-rendering the searchbar afterward.
The search query was forgotten when the Items list reloaded or the Items list page was re-entered from an Item detail page.
This is also fixed by using
$f7.datato store the query.