Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix alexa item group type parameter support #2194

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Fix alexa item group type parameter support #2194

merged 1 commit into from
Dec 5, 2023

Conversation

jsetton
Copy link
Contributor

@jsetton jsetton commented Dec 1, 2023

No description provided.

@jsetton
Fix alexa item group type parameter support
d4872dd 
Signed-off-by: jsetton <jeremy.setton@gmail.com>
@jsetton jsetton requested a review from a team as a code owner December 1, 2023 20:26
@relativeci RelativeCI
Copy link

relativeci bot commented Dec 1, 2023

Job #1281: Bundle Size — 15.81MiB (+0.31%).

d4872dd(current) vs b7270d2 main#1158(baseline)

Important

Bundle introduced 1 and removed 1 duplicate package – View changed duplicate packages

Warning

Bundle introduced 13 new packages: @jsep-plugin/regex, @jsep-plugin/arrow, @jsep-plugin/object and 10 more – View changed packages

Bundle metrics  Change 10 changes Regression 5 regressions Improvement 1 improvement
                 Current
Job #1281		      Baseline
Job #1158
Regression  Initial JS 1.89MiB(+13.18%) 1.67MiB
Regression  Initial CSS 609.63KiB(+0.12%) 608.89KiB
Change  Cache Invalidation 93.81% 93.95%
Change  Chunks 217(-0.91%) 219
Change  Assets 683(-0.87%) 689
Change  Modules 3027(+78.06%) 1700
Regression  Duplicate Modules 173(+92.22%) 90
Improvement  Duplicate Code 1.61%(-17.44%) 1.95%
Regression  Packages 152(+10.14%) 138
Regression  Duplicate Packages 16(+6.67%) 15
Bundle size by type  Change 3 changes Regression 3 regressions
                 Current
Job #1281		      Baseline
Job #1158
Regression  JS 9.29MiB (+0.34%) 9.25MiB
Regression  Other 4.74MiB (+0.34%) 4.73MiB
Regression  CSS 860.87KiB (+0.16%) 859.49KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.23KiB 1.23KiB

View job #1281 report View jsetton:alexa-group-type-param branch activity

florian-h05
florian-h05 approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

I haven't tested this since I don't use Alexa metadata, but I'll trust you as Alexa maintainer.

@florian-h05 florian-h05 added bug Something isn't working main ui Main UI labels Dec 5, 2023
@florian-h05 florian-h05 added this to the 4.1 milestone Dec 5, 2023
@florian-h05 florian-h05 merged commit 5a9c0c9 into openhab:main Dec 5, 2023
6 checks passed
@jsetton jsetton deleted the alexa-group-type-param branch December 5, 2023 23:14
@jsetton jsetton mentioned this pull request Feb 16, 2024
Merged
florian-h05 pushed a commit that referenced this pull request Feb 16, 2024
@jsetton
Fix alexa thermostat attribute parameters (#2364)
344779a 
Breakage introduced by #2194

Signed-off-by: jsetton <jeremy.setton@gmail.com>
florian-h05 pushed a commit that referenced this pull request Feb 17, 2024
@jsetton @florian-h05
Fix alexa thermostat attribute parameters (#2364)
974a864 
Breakage introduced by #2194

Signed-off-by: jsetton <jeremy.setton@gmail.com>
(cherry picked from commit 344779a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florian-h05 florian-h05 florian-h05 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working main ui Main UI
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@jsetton @florian-h05