-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add panel for voiceSystem metadata #2222
Conversation
Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
Job #1323: Bundle Size — 15.84MiB (+0.47%).Important Bundle introduced 1 and removed 1 duplicate package – View changed duplicate packages Warning Bundle introduced 13 new packages: @jsep-plugin/regex, @jsep-plugin/arrow, @jsep-plugin/object and 10 more – View changed packages Bundle metrics
Bundle size by type
View job #1323 report View GiviMAD:ui/voicesystem_metadata branch activity |
Thanks @GiviMAD - I've been following your work and having a generic voice system is great.
|
Thank you for the review and the comments! I've updated the PR. |
Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
6c21fc7
to
0c55263
Compare
Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
The required core PR has been merged. |
@florian-h05 @ghys would you be able to review the PR so it can get into the last milestone? Thank you in advance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Just some minor thing: We ususally spell Item
uppercase as it is a openHAB term. I will fix that myself to get this merged soon.
BTW: I am looking forward to see some docs for this new feature so I could try this out at some point in time. |
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Thank you for the review! Yes, I have a brief of the functionality written in one of the PRs. I think with some changes it could be an entendible documentation page. I'll look at it, I've never updated the documentation before. |
Hello, I would like to add these panel for editing the item voiceSystem namespace.
It needs to wait for the review of these core PR openhab/openhab-core#3925 , hope it's fine to open the PR anyway.
Screenshots: