Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add panel for voiceSystem metadata #2222

Merged
merged 4 commits into from
Dec 17, 2023

Conversation

GiviMAD
Copy link
Member

@GiviMAD GiviMAD commented Dec 15, 2023

Hello, I would like to add these panel for editing the item voiceSystem namespace.

It needs to wait for the review of these core PR openhab/openhab-core#3925 , hope it's fine to open the PR anyway.

Screenshots:

Screenshot 2023-12-15 at 22 23 46 Screenshot 2023-12-15 at 20 16 22 Screenshot 2023-12-15 at 22 20 30

Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
@GiviMAD GiviMAD requested a review from a team as a code owner December 15, 2023 19:18
Copy link

relativeci bot commented Dec 15, 2023

Job #1323: Bundle Size — 15.84MiB (+0.47%).

c29ec73(current) vs b7270d2 main#1158(baseline)

Important

Bundle introduced 1 and removed 1 duplicate package – View changed duplicate packages

Warning

Bundle introduced 13 new packages: @jsep-plugin/regex, @jsep-plugin/arrow, @jsep-plugin/object and 10 more – View changed packages

Bundle metrics  Change 10 changes Regression 5 regressions Improvement 1 improvement
                 Current
Job #1323
     Baseline
Job #1158
Regression  Initial JS 1.9MiB(+13.75%) 1.67MiB
Regression  Initial CSS 609.75KiB(+0.14%) 608.89KiB
Change  Cache Invalidation 93.81% 93.95%
Change  Chunks 217(-0.91%) 219
Change  Assets 683(-0.87%) 689
Change  Modules 3033(+78.41%) 1700
Regression  Duplicate Modules 170(+88.89%) 90
Improvement  Duplicate Code 1.6%(-17.95%) 1.95%
Regression  Packages 152(+10.14%) 138
Regression  Duplicate Packages 16(+6.67%) 15
Bundle size by type  Change 3 changes Regression 3 regressions
                 Current
Job #1323
     Baseline
Job #1158
Regression  JS 9.3MiB (+0.53%) 9.25MiB
Regression  Other 4.75MiB (+0.49%) 4.73MiB
Regression  CSS 861.19KiB (+0.2%) 859.49KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.23KiB 1.23KiB

View job #1323 reportView GiviMAD:ui/voicesystem_metadata branch activity

@ghys
Copy link
Member

ghys commented Dec 15, 2023

Thanks @GiviMAD - I've been following your work and having a generic voice system is great.
Regarding this PR I have a couple early cosmetic change requests:

@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI awaiting other PR Depends on another PR labels Dec 15, 2023
@GiviMAD
Copy link
Member Author

GiviMAD commented Dec 15, 2023

Thank you for the review and the comments! I've updated the PR.

Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
@GiviMAD GiviMAD force-pushed the ui/voicesystem_metadata branch from 6c21fc7 to 0c55263 Compare December 15, 2023 21:24
Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
@GiviMAD
Copy link
Member Author

GiviMAD commented Dec 16, 2023

The required core PR has been merged.

@GiviMAD
Copy link
Member Author

GiviMAD commented Dec 16, 2023

@florian-h05 @ghys would you be able to review the PR so it can get into the last milestone? Thank you in advance.

@florian-h05 florian-h05 removed the awaiting other PR Depends on another PR label Dec 17, 2023
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Just some minor thing: We ususally spell Item uppercase as it is a openHAB term. I will fix that myself to get this merged soon.

@florian-h05
Copy link
Contributor

BTW: I am looking forward to see some docs for this new feature so I could try this out at some point in time.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 added this to the 4.1 milestone Dec 17, 2023
@florian-h05 florian-h05 merged commit d52296a into openhab:main Dec 17, 2023
6 checks passed
@GiviMAD
Copy link
Member Author

GiviMAD commented Dec 17, 2023

Thank you for the review!

Yes, I have a brief of the functionality written in one of the PRs. I think with some changes it could be an entendible documentation page. I'll look at it, I've never updated the documentation before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants