Disable suggestion for installed add-ons #2226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mherwege
force-pushed
the
suggestions
branch
from
bca23f4 to
88e12b5
Compare
Job #1328: Bundle Size — 15.84MiB (+0.47%).Important Bundle introduced 1 and removed 1 duplicate package – View changed duplicate packages Warning Bundle introduced 13 new packages: @jsep-plugin/regex, @jsep-plugin/arrow, @jsep-plugin/object and 10 more – View changed packages Bundle metrics
  
Bundle size by type
View job #1328 report View mherwege:suggestions branch activity |
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
mherwege
force-pushed
the
suggestions
branch
from
88e12b5 to
d12f72c
Compare
|
Ok, we should try to include that PR in 4.1RC. |
|
I will review that today 👍 |
florian-h05
reviewed
Dec 19, 2023
| @@ -226,7 +226,7 @@ export default { | |||
| return Object.keys(this.addons).flatMap((k) => this.addons[k]) | |||
| }, | |||
| suggestedAddons () { | |||
| return Object.keys(this.addons).flatMap((k) => this.addons[k]).filter((a) => this.suggestions.some((s) => s.id === a.id)) | |||
| return Object.keys(this.addons).flatMap((k) => this.addons[k]).filter((a) => !a.isInstalled && this.suggestions.some((s) => s.id === a.id)) | |||
There was a problem hiding this comment.
Suggested change
| return Object.keys(this.addons).flatMap((k) => this.addons[k]).filter((a) => !a.isInstalled && this.suggestions.some((s) => s.id === a.id)) | |
| return Object.keys(this.addons).flatMap((k) => this.addons[k]).filter((a) => !a.installed && this.suggestions.some((s) => s.id === a.id)) |
florian-h05
approved these changes
Dec 19, 2023
florian-h05
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggestions are being shown in the add-on store for add-ons that are already installed.
This PR removes suggestions for installed add-ons.
See request here openhab/openhab-core#3868 (comment)