-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BasicUI] Fix icon none #2231
[BasicUI] Fix icon none #2231
Conversation
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
I just wonder whether /images/none.png
works, because the resource folder contains that image.
Anyway, I think this PR can be merged as a quick fix. I won‘t be at home in time so I cannot try out if there is a better solution.
@kaikreuzer WDYT? |
I'm just looking at it - I would change as little as possible; as you say, the image exists, so it's rather a matter of fixing the icon. I'm trying to debug locally now. |
Argh, bad timing; my Internet connection just broken and I am also having trouble running the npm part of the Basic UI build locally -> I am failing to test it locally right now. 😢 |
I‘m on the way home but it’ll definitely take till 1 pm … and unfortunately I also don’t have my notebook with me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, I would also say the fix looks good.
So let's merge it and quickly test it on a new snapshot.
And once the release is done we can have a look at fixing it in a cleaner way 👍 |
I successfully tested the fix! |
Thank you guys. Normally images/none.png should exist, it is one of the PNG file packaged with Basic UI. Here is the link: So you probably changed more things than expected. |
I probably have. I was mislead by https://community.openhab.org/t/openhab-4-1-milestone-discussion/149502/226 stating images/none.png not existing, but it was using the wrong path, as the URL would have to be http://openHAB:8080/basicui/images/none.png to test. |
See comment #2231 (comment) This is the minimal fix to the issue. Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
See comment #2231 (comment) This is the minimal fix to the issue. Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
As described in https://community.openhab.org/t/openhab-4-1-milestone-discussion/149502/222, none.png is not found for BasicUI.
This PR replaces it with non.svg, see discussion on forum.
@lolodomo @florian-h05 I was behind my screen when I saw the issue. I didn't test, but did the replacement based on info provided on the forum.