Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config sheet: Show advanced params if not default or not empty #2313

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Config sheet: Show advanced params if not default or not empty #2313

merged 2 commits into from
Feb 9, 2024

Conversation

florian-h05
Copy link
Contributor

@florian-h05 florian-h05 commented Feb 6, 2024 •
edited
Loading

Advanced parameters should be shown to the user if they have:

  • a default value defined and the value is not the default value
  • no default value defined and they have a value set

This is more transparent to the user and improves the UX, because the user does not need to enable "show advanced" just to check whether he has set up advanced parameters.

@florian-h05
Config sheet: Show advanced params if they don't equal the default or…
6ab20c1 
… are not empty

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 requested a review from a team as a code owner February 6, 2024 19:52
@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Feb 6, 2024
@florian-h05 florian-h05 added this to the 4.2 milestone Feb 6, 2024
@florian-h05 florian-h05 mentioned this pull request Feb 6, 2024
Merged
@florian-h05 florian-h05 changed the title Config sheet: Show advanced params if they don't equal the default or… Config sheet: Show advanced params if not default or not empty Feb 6, 2024
@florian-h05
Fix lint
e5cf1bc 
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@relativeci RelativeCI
Copy link

relativeci bot commented Feb 6, 2024

Job #1427: Bundle Size — 11MiB (~+0.01%).

e5cf1bc(current) vs 93dce56 main#1413(baseline)

Warning

Bundle contains 19 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
Job #1427		      Baseline
Job #1413
Regression  Initial JS 1.84MiB(~+0.01%) 1.84MiB
No change  Initial CSS 607.73KiB 607.73KiB
Change  Cache Invalidation 18.29% 17.52%
No change  Chunks 220 220
No change  Assets 242 242
No change  Modules 3074 3074
No change  Duplicate Modules 159 159
No change  Duplicate Code 1.74% 1.74%
No change  Packages 150 150
No change  Duplicate Packages 18 18
Bundle size by type  Change 1 change Regression 1 regression
                 Current
Job #1427		      Baseline
Job #1413
Regression  JS 9.19MiB (~+0.01%) 9.19MiB
Not changed  CSS 888.86KiB 888.86KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.24KiB 1.24KiB
Not changed  Other 871B 871B

View job #1427 report View florian-h05:config-sheet-advance... branch activity View project dashboard

@stefan-hoehn
Copy link
Contributor

As explained to Florian

"This is more of a behavioral change than a visual one ... The point is that if, for example, you use the API security configuration and change an advanced setting there, it should then always be displayed without having to activate "Show Advanced". So as soon as an "advanced" setting is not at its default value, it is always displayed, even if "Show Advanced" is not activated."

stefan-hoehn
stefan-hoehn approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@stefan-hoehn stefan-hoehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@florian-h05 florian-h05 merged commit fff3d0e into openhab:main Feb 9, 2024
6 checks passed
@florian-h05 florian-h05 deleted the config-sheet-advanced branch February 9, 2024 18:21
@florian-h05 florian-h05 mentioned this pull request Dec 1, 2024
Merged
florian-h05 added a commit that referenced this pull request Dec 3, 2024
@florian-h05
Config sheet: Always show advanced params only if changed from default (
1258cf0 
#2888)

Improve code from #2313.
Closes #2879.

---------

Signed-off-by: Florian Hotze <dev@florianhotze.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefan-hoehn stefan-hoehn stefan-hoehn approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
2 participants
@florian-h05 @stefan-hoehn