Sitemap editor: Add press release button support #2553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#1943 Bundle Size — 10.59MiB (+0.02%).Warning Bundle contains 2 duplicate packages – View duplicate packages Bundle metrics
|
| Current #1943 |
Baseline #1941 |
|
|---|---|---|
 Initial JS |
1.86MiB |
1.86MiB |
| Initial CSS |
607.87KiB |
607.87KiB |
 Cache Invalidation |
17.76% |
17.77% |
| Chunks |
222 |
222 |
| Assets |
245 |
245 |
| Modules |
2873 |
2873 |
| Duplicate Modules |
146 |
146 |
| Duplicate Code |
1.84% |
1.84% |
| Packages |
95 |
95 |
| Duplicate Packages |
2 |
2 |
Bundle size by type 1 change 
1 regression
| Current #1943 |
Baseline #1941 |
|
|---|---|---|
| JS |
8.78MiB (+0.02%) |
8.77MiB |
| CSS |
890.63KiB |
890.63KiB |
| Fonts |
526.1KiB |
526.1KiB |
| Media |
295.6KiB |
295.6KiB |
| IMG |
140.74KiB |
140.74KiB |
| HTML |
1.24KiB |
1.24KiB |
| Other |
871B |
871B |
Bundle analysis report Branch mherwege:press_release_button Project dashboard
florian-h05
added
awaiting other PR
|
Ready for review, the core PRs are now merged. |
lolodomo
added
rebuild
|
@mherwege : please rebase your branch. Build is failing due to a change in core framework that needed a fix in Basic UI. |
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
mherwege
force-pushed
the
press_release_button
branch
from
dbb8d01 to
725e626
Compare
|
@lolodomo done |
florian-h05
changed the title
florian-h05
changed the title
florian-h05
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to openhab/openhab-core#4183
Requires openhab/openhab-core#4204
This PR implements press/release button support.
To make this work, some refactoring had to be done to allow proper quoting of arguments in mappings and conditions. So far, quotes where stripped and the full mapping or condition strings where interpreted by splitting on special characters (=, : ...). This is limiting as it blocks these characters from being used in the arguments or makes working with blanks difficult. The sitemap syntax explicitely works with quoted strings for this, but that information was lost in the current implementation.
Quotes are now preserved, and therefore they need to be removed in core at usage (openhab/openhab-core#4204).
Note that this introduced a backward compatibility constraint, as sitemaps saved in the UI, containing mappings or conditions with blanks, will require quotes to be manually added in the UI in order to be able to save changes to it. If not touched, the sitemaps should still work.