Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Developer sidebar: Fix script and scene "unpin all" links #2640

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Developer sidebar: Fix script and scene "unpin all" links #2640

merged 1 commit into from
Jul 4, 2024

Conversation

JustinGeorgi
Copy link
Contributor

The links to unpin scenes and scripts in the dev toolbar were set to 'rules' instead of the correct specifics, and so, didn't work.

@JustinGeorgi
Fix script and scene unpin all links
2faec61 
Signed-off-by: Justin Georgi <justin.georgi@gmail.com>
@JustinGeorgi JustinGeorgi requested a review from a team as a code owner July 4, 2024 02:09
@relativeci RelativeCI
Copy link

relativeci bot commented Jul 4, 2024

#2089 Bundle Size — 10.68MiB (~-0.01%).

2faec61(current) vs 57749b4 main#2088(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Improvement 1 improvement
                 Current
#2089		      Baseline
#2088
Improvement  Initial JS 1.88MiB(~-0.01%) 1.88MiB
No change  Initial CSS 607.91KiB 607.91KiB
Change  Cache Invalidation 17.83% 18.58%
No change  Chunks 223 223
No change  Assets 246 246
No change  Modules 2894 2894
No change  Duplicate Modules 149 149
No change  Duplicate Code 1.85% 1.85%
No change  Packages 97 97
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Improvement 1 improvement
                 Current
#2089		      Baseline
#2088
Improvement  JS 8.86MiB (~-0.01%) 8.86MiB
No change  CSS 891.55KiB 891.55KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.24KiB 1.24KiB
No change  Other 871B 871B

Bundle analysis report Branch JustinGeorgi:jag-fix-unpin Project dashboard

florian-h05
florian-h05 approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@florian-h05 florian-h05 added bug Something isn't working main ui Main UI labels Jul 4, 2024
@florian-h05 florian-h05 added this to the 4.2 milestone Jul 4, 2024
@florian-h05 florian-h05 changed the title Fix script and scene unpin all links Developer sidebar: Fix script and scene "unpin all" links Jul 4, 2024
@florian-h05 florian-h05 merged commit 82c937e into openhab:main Jul 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florian-h05 florian-h05 florian-h05 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working main ui Main UI
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
2 participants
@JustinGeorgi @florian-h05