[blockly] Add new sophisticated notification blocks

[stefan-hoehn]

This is probably the most comprehensive block I have provided so far which supports the awesome cloud notification functionality that was provided recently. Kudos to all who have provided the cloud notifications and added them to the apps! ❤️

Thanks for the support during this implementation to Florian, Dan, Danny, Matthias (and the rest of the openHAB foundation gang who provided feedback and nice ideas to make it even better).

I tested all of the above use cases and I hope I covered most of it.

Note that the new blocks can completely replace the old ones (though they will not be automatically converted but it must be done manually). I will document this eventually in the blockly docs.

The new notification blocks:

The block can be highly customized by showing or hiding the required inputs:

Without user ids, it will result into a broadcast. Individual users can be address with a comma separated list:

You can provide actions (directly or further down below via up to three clickable buttons in the notification)

Two different types of actions are available to attach to direct action or a button action

Action:

Button 1/2/3 Action

Action Blocks

Actions can be provided via blocks are generically via Strings:

Many more examples:

Based on

https://www.openhab.org/addons/integrations/openhabcloud/#cloud-notification-actions
https://www.openhab.org/addons/automation/jsscripting/#cloud-notification-actions

Here is an example in the Android app with included media:

[relativeci]

#2138 Bundle Size — 10.77MiB (+0.91%).

9dc7daf(current) vs bc73c9e main#2134(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics   2 changes

	Current #2138	Baseline #2134
Initial JS	1.88MiB	1.88MiB
Initial CSS	607.91KiB	607.91KiB
Cache Invalidation	18.22%	17.96%
Chunks	223	223
Assets	246	246
Modules	2888	2888
Duplicate Modules	149	149
Duplicate Code	1.84%(-0.54%)	1.85%
Packages	97	97
Duplicate Packages	2	2

Bundle size by type   1 change 1 regression

	Current #2138	Baseline #2134
JS	8.96MiB (+1.1%)	8.86MiB
CSS	892.47KiB	892.47KiB
Fonts	526.1KiB	526.1KiB
Media	295.6KiB	295.6KiB
IMG	140.74KiB	140.74KiB
HTML	1.24KiB	1.24KiB
Other	871B	871B

---

Bundle analysis report Branch stefan-hoehn:blockly_notificatio... Project dashboard

[maniac103]

The action button syntax seems a little cumbersome. I assume splitting label and action there is not possible?

[stefan-hoehn]

I assume splitting label and action there is not possible?

Kinda correct. I thought about it The problem is that it would require a special designed "command-button" input block that contains two inputs by itself. It would require a special "command block" to be implemented and a very special handling in that case. It could maybe be done but surely is a much more complex implementation while I don't think it is actually not too bad the way it is...

[stefan-hoehn]

The action button syntax seems a little cumbersome. I assume splitting label and action there is not possible?

I did a proof-of-concept: this is how it would look like. Do you think this is better?

[stefan-hoehn]

And one more comment, @maniac103

• it must be of course "action" and not message in the above screenshot
• and we had a board meeting today and so I took the change to ask for design ideas and we actually came up with the idea to make it even more sophisticated by providing special blocks of action types where the item-action could for example even support the item picker.

So stay tuned for an update.

[maniac103]

it must be of course "action" and not message in the above screenshot

I assume you mean 'and not command', right?

But I indeed think that's much better, but...

we actually came up with the idea to make it even more sophisticated by providing special blocks of action types where the item-action could for example even support the item picker.

...is beaten by this approach which sounds awesome 👍

[stefan-hoehn]

first idea (only design, still needs to be implemented).

[florian-h05]

Overall already looks good, please have a look at my comments.

I also have a few wording remarks:

Replace "with Action" -> "with On-Click Action" and rename the action button block's "on-click action" -> "action".

Are shadow blocks inside me screenshot expected to work? I think in blockly-editor.vue are a few input names wrongly defined.

[stefan-hoehn]

Are shadow blocks inside my screenshot expected to work? I think in blockly-editor.vue are a few input names wrongly defined.

The ones here

don't actually have shadow blocks because I would have to create them in the code which would require a lot of extra non-generic code for these blocks. So, no, for these you have to drop in your own blocks. However, you can only add the right block types to them.

[florian-h05]

LGTM now, I have just pushed a few minor changes - thanks for your great work!

[stefan-hoehn]

Unfortunately I found a few bugs and I am already working on it. The fix will come very soon.