Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overview page: Fix defineVars is not working #2673

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Overview page: Fix defineVars is not working #2673

merged 1 commit into from
Jul 15, 2024

Conversation

florian-h05
Copy link
Contributor

Fixes #2046.

@florian-h05
Overview page: Fix defineVars config is not working
d4d23b4 
Fixes openhab#2046.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 requested a review from a team as a code owner July 15, 2024 17:34
@florian-h05 florian-h05 mentioned this pull request Jul 15, 2024
Closed
@florian-h05 florian-h05 changed the title Overview page: Fix defineVars config is not working Overview page: Fix defineVars is not working Jul 15, 2024
@florian-h05 florian-h05 added bug Something isn't working main ui Main UI labels Jul 15, 2024
@florian-h05 florian-h05 added this to the 4.3 milestone Jul 15, 2024
@relativeci RelativeCI
Copy link

relativeci bot commented Jul 15, 2024

#2122 Bundle Size — 10.67MiB (~+0.01%).

d4d23b4(current) vs b5e6c34 main#2120(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change Regression 1 regression
                 Current
#2122		      Baseline
#2120
Regression  Initial JS 1.88MiB(~+0.01%) 1.88MiB
No change  Initial CSS 607.91KiB 607.91KiB
No change  Cache Invalidation 17.59% 17.59%
No change  Chunks 223 223
No change  Assets 246 246
No change  Modules 2888 2888
No change  Duplicate Modules 149 149
No change  Duplicate Code 1.85% 1.85%
No change  Packages 97 97
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#2122		      Baseline
#2120
Regression  JS 8.86MiB (~+0.01%) 8.86MiB
No change  CSS 892.63KiB 892.63KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.24KiB 1.24KiB
No change  Other 871B 871B

Bundle analysis report Branch florian-h05:overview-tab-definev... Project dashboard

@florian-h05 florian-h05 merged commit 9791035 into openhab:main Jul 15, 2024
8 checks passed
@florian-h05 florian-h05 deleted the overview-tab-definevars branch July 15, 2024 18:26
florian-h05 added a commit that referenced this pull request Jul 15, 2024
@florian-h05
Overview page: Fix defineVars is not working (#2673)
c9336d6 
Fixes #2046.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
(cherry picked from commit 9791035)
@florian-h05 florian-h05 added the patch A PR that has been cherry-picked to a patch release branch label Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working main ui Main UI patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

[MainUI] Overview Page prevents variables from working correctly in widgets etc
1 participant
@florian-h05