Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[blockly] Fix code generation for Thing object on Thing status block #2688

Merged
merged 1 commit into from
Jul 26, 2024
Merged

[blockly] Fix code generation for Thing object on Thing status block #2688

merged 1 commit into from
Jul 26, 2024

Conversation

stefan-hoehn
Copy link
Contributor

fixes #2670

image

@stefan-hoehn
[blockly] support thing on thing status block
6c0e424 
Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
@stefan-hoehn stefan-hoehn requested a review from a team as a code owner July 26, 2024 11:03
@relativeci RelativeCI
Copy link

relativeci bot commented Jul 26, 2024

#2145 Bundle Size — 10.77MiB (~+0.01%).

6c0e424(current) vs 0c03554 main#2142(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  no changes
                 Current
#2145		      Baseline
#2142
No change  Initial JS 1.88MiB 1.88MiB
No change  Initial CSS 607.91KiB 607.91KiB
No change  Cache Invalidation 17.96% 17.96%
No change  Chunks 223 223
No change  Assets 246 246
No change  Modules 2888 2888
No change  Duplicate Modules 149 149
No change  Duplicate Code 1.84% 1.84%
No change  Packages 97 97
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#2145		      Baseline
#2142
Regression  JS 8.96MiB (~+0.01%) 8.96MiB
No change  CSS 892.47KiB 892.47KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.24KiB 1.24KiB
No change  Other 871B 871B

Bundle analysis report Branch stefan-hoehn:blockly_things_impr... Project dashboard

florian-h05
florian-h05 approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
I will backport this to 4.2.x.

@florian-h05 florian-h05 added bug Something isn't working main ui Main UI patch A PR that has been cherry-picked to a patch release branch labels Jul 26, 2024
@florian-h05 florian-h05 added this to the 4.3 milestone Jul 26, 2024
@florian-h05 florian-h05 changed the title [blockly] support thing on thing status block [blockly] Fix code generation for Thing object on Thing status block Jul 26, 2024
@florian-h05 florian-h05 merged commit 2de240e into openhab:main Jul 26, 2024
8 checks passed
@florian-h05 florian-h05 deleted the blockly_things_improvement branch July 26, 2024 11:16
florian-h05 pushed a commit that referenced this pull request Jul 26, 2024
@stefan-hoehn @florian-h05
[blockly] Fix code generation for Thing object on Thing status block (#…
7d53839 
…2688)

Fixes #2670.

Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
(cherry picked from commit 2de240e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florian-h05 florian-h05 florian-h05 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working main ui Main UI patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Milestone
4.3
2 participants
@stefan-hoehn @florian-h05