Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link add: Fix create item fails for trigger channels #2689

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Link add: Fix create item fails for trigger channels #2689

merged 1 commit into from
Jul 26, 2024

Conversation

florian-h05
Copy link
Contributor

Regression from #2312.
Fixes #2669.

@florian-h05
Link add: Fix create item fails for trigger channels
038a90c 
Regression from openhab#2312.
Fixes openhab#2669.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 requested a review from a team as a code owner July 26, 2024 12:03
@florian-h05 florian-h05 added bug Something isn't working main ui Main UI patch A PR that has been cherry-picked to a patch release branch labels Jul 26, 2024
@florian-h05 florian-h05 added this to the 4.3 milestone Jul 26, 2024
@relativeci RelativeCI
Copy link

relativeci bot commented Jul 26, 2024

#2147 Bundle Size — 10.77MiB (~+0.01%).

038a90c(current) vs 2de240e main#2146(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change
                 Current
#2147		      Baseline
#2146
No change  Initial JS 1.88MiB 1.88MiB
No change  Initial CSS 607.91KiB 607.91KiB
Change  Cache Invalidation 18.11% 17.96%
No change  Chunks 223 223
No change  Assets 246 246
No change  Modules 2888 2888
No change  Duplicate Modules 149 149
No change  Duplicate Code 1.84% 1.84%
No change  Packages 97 97
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#2147		      Baseline
#2146
Regression  JS 8.96MiB (~+0.01%) 8.96MiB
No change  CSS 892.47KiB 892.47KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.24KiB 1.24KiB
No change  Other 871B 871B

Bundle analysis report Branch florian-h05:link-add-item-linkin... Project dashboard

@florian-h05 florian-h05 merged commit fa85c07 into openhab:main Jul 26, 2024
8 checks passed
@florian-h05 florian-h05 deleted the link-add-item-linking branch July 26, 2024 12:16
florian-h05 added a commit that referenced this pull request Jul 26, 2024
@florian-h05
Link add: Fix create item fails for trigger channels (#2689)
091d0ed 
Regression from #2312.
Fixes #2669.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
(cherry picked from commit fa85c07)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working main ui Main UI patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

[MainUI] Adding items to trigger-based channel is broken
1 participant
@florian-h05