Update HomeKit metadata definitions #2691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cody Cutrer <cody@cutrer.us>
Signed-off-by: Cody Cutrer <cody@cutrer.us>
Signed-off-by: Cody Cutrer <cody@cutrer.us>
Signed-off-by: Cody Cutrer <cody@cutrer.us>
Signed-off-by: Cody Cutrer <cody@cutrer.us>
Inverted param, enums for all characteristics (including on the accessory itself if it makes sense), configuration options, and metadata characteristics Signed-off-by: Cody Cutrer <cody@cutrer.us>
ccutrer
force-pushed
the
homekit-metadata-update
branch
from
7f35b8b to
52e94c3
Compare
|
You may want to look at the commits individually, since one of them sorts them all. cc @yfre |
#2153 Bundle Size — 10.78MiB (+0.13%).Warning Bundle contains 2 duplicate packages – View duplicate packages Bundle metrics
|
| Current #2153 |
Baseline #2150 |
|
|---|---|---|
 Initial JS |
1.88MiB |
1.88MiB |
| Initial CSS |
607.91KiB |
607.91KiB |
| Cache Invalidation |
18.11% |
18.11% |
| Chunks |
223 |
223 |
| Assets |
246 |
246 |
| Modules |
2888 |
2888 |
| Duplicate Modules |
149 |
149 |
| Duplicate Code |
1.84% |
1.84% |
| Packages |
97 |
97 |
| Duplicate Packages |
2 |
2 |
Bundle size by type 
1 change 
1 regression
| Current #2153 |
Baseline #2150 |
|
|---|---|---|
| JS |
8.97MiB (+0.15%) |
8.96MiB |
| CSS |
892.47KiB |
892.47KiB |
| Fonts |
526.1KiB |
526.1KiB |
| Media |
295.6KiB |
295.6KiB |
| IMG |
140.74KiB |
140.74KiB |
| HTML |
1.24KiB |
1.24KiB |
| Other |
871B |
871B |
Bundle analysis report Branch ccutrer:homekit-metadata-update Project dashboard
Signed-off-by: Cody Cutrer <cody@cutrer.us>
florian-h05
approved these changes
Jul 30, 2024
|
Let‘s wait a few days for @yfre so he can have a look if he wants to. |
florian-h05
changed the title
|
Let's merge this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing accessories, configuration parameters, enums, etc.