[cometvisu] Add more path checks and secure against XXE attacks #2696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tobias Bräutigam <tbraeutigam@gmail.com>
Signed-off-by: Tobias Bräutigam <tbraeutigam@gmail.com>
Signed-off-by: Tobias Bräutigam <tbraeutigam@gmail.com>
Signed-off-by: Tobias Bräutigam <tbraeutigam@gmail.com>
kaikreuzer
reviewed
Aug 5, 2024
...g.openhab.ui.cometvisu/src/main/java/org/openhab/ui/cometvisu/internal/util/MountedFile.java
Outdated
Show resolved
Hide resolved
|
Please also adapt the title and description of this PR to provide some more details - thanks! |
|
@peuter Please also note that there is a new comment on the advisory. |
peuter
changed the title
Signed-off-by: Tobias Bräutigam <tbraeutigam@gmail.com>
Signed-off-by: Tobias Bräutigam <tbraeutigam@gmail.com>
kaikreuzer
changed the title
kaikreuzer
pushed a commit
to kaikreuzer/openhab-webui
that referenced
this pull request
Aug 8, 2024
also deny external xml schema loading (avoid XXE attacks) Signed-off-by: Tobias Bräutigam <tbraeutigam@gmail.com>
kaikreuzer
added
patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also deny external xml schema loading (avoid XXE attacks)