Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cometvisu] fix path check regressions #2719

Merged
merged 1 commit into from
Aug 21, 2024
Merged

[cometvisu] fix path check regressions #2719

merged 1 commit into from
Aug 21, 2024

Conversation

peuter
Copy link
Member

@peuter peuter commented Aug 19, 2024

  1. Fix serving the index.html when "/" (or empty) path is requested
  2. Fix allowing files beeing served from special cometvisu config folder

@peuter
fix some regressions introduced with the latest security fixes:
11a6651 
1. Fix serving the index.html when "/" (or empty) path is requested
2. Fix allowing files beeing served from special cometvisu config folder

Signed-off-by: Tobias Bräutigam <tbraeutigam@gmail.com>
@peuter peuter added cometvisu ui Cometvisu UI bug Something isn't working labels Aug 19, 2024
@peuter peuter requested a review from a team August 19, 2024 15:39
kaikreuzer
kaikreuzer approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kaikreuzer kaikreuzer merged commit 51d2811 into openhab:main Aug 21, 2024
5 checks passed
@kaikreuzer
Copy link
Member

@peuter Is this something critical that should be backported to 4.2.x or is it fine to only fix it on main?

@kaikreuzer kaikreuzer added this to the 4.3 milestone Aug 21, 2024
@peuter
Copy link
Member Author

peuter commented Aug 21, 2024

A Backport to 4.2 would be great. For one of the problems this PR fixes we do not have a workaround and it breaks a quite common and useful use case.

kaikreuzer pushed a commit to kaikreuzer/openhab-webui that referenced this pull request Aug 23, 2024
@peuter @kaikreuzer
[cometvisu] fix path check regressions (openhab#2719)
df1a5c2 
1. Fix serving the index.html when "/" (or empty) path is requested
2. Fix allowing files beeing served from special cometvisu config folder

Signed-off-by: Tobias Bräutigam <tbraeutigam@gmail.com>
@kaikreuzer
Copy link
Member

Done!

@kaikreuzer kaikreuzer added the patch A PR that has been cherry-picked to a patch release branch label Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaikreuzer kaikreuzer kaikreuzer approved these changes

Assignees
No one assigned
Labels
bug Something isn't working cometvisu ui Cometvisu UI patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@peuter @kaikreuzer