Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Developer sidebar: Focus on search when opened #2731

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Developer sidebar: Focus on search when opened #2731

merged 2 commits into from
Aug 26, 2024

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Aug 26, 2024

Resolve #2727

@jimtng
Focus on developer sidebar search when opened
655f8b0 
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@jimtng jimtng requested a review from a team as a code owner August 26, 2024 01:01
@relativeci RelativeCI
Copy link

relativeci bot commented Aug 26, 2024 •
edited
Loading

#2220 Bundle Size — 10.83MiB (~+0.01%).

f441acd(current) vs 77dbfcb main#2217(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#2220		      Baseline
#2217
Regression  Initial JS 1.89MiB(~+0.01%) 1.89MiB
No change  Initial CSS 576.5KiB 576.5KiB
Change  Cache Invalidation 17.67% 18.13%
No change  Chunks 226 226
No change  Assets 249 249
No change  Modules 2914 2914
No change  Duplicate Modules 149 149
No change  Duplicate Code 1.8% 1.8%
No change  Packages 96 96
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#2220		      Baseline
#2217
Regression  JS 9.05MiB (~+0.01%) 9.05MiB
No change  CSS 862.92KiB 862.92KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.35KiB 1.35KiB
No change  Other 871B 871B

Bundle analysis report Branch jimtng:devtool-searchbar-focus Project dashboard

Generated by RelativeCI Documentation Report issue

@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Aug 26, 2024
@jimtng
use nextTick, only on desktop
f441acd 
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
florian-h05
florian-h05 approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@florian-h05 florian-h05 changed the title Focus on developer sidebar search when opened Developer sidebar: Focus on search when opened Aug 26, 2024
@florian-h05 florian-h05 merged commit 5716165 into openhab:main Aug 26, 2024
8 checks passed
@florian-h05 florian-h05 added this to the 4.3 milestone Aug 26, 2024
@jimtng jimtng deleted the devtool-searchbar-focus branch August 27, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florian-h05 florian-h05 florian-h05 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Main UI developer sidebar -> automatic focus
2 participants
@jimtng @florian-h05