[blockly] Small improvements to blocks #2742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
mherwege
force-pushed
the
blockly_persistence
branch
from
851c89b to
41a03e4
Compare
#2249 Bundle Size — 10.83MiB (~+0.01%).157a586(current) vs 920466e main#2248(baseline) Warning Bundle contains 2 duplicate packages – View duplicate packages Bundle metrics
|
| Current #2249 |
Baseline #2248 |
|
|---|---|---|
 Initial JS |
1.89MiB |
1.89MiB |
| Initial CSS |
576.5KiB |
576.5KiB |
 Cache Invalidation |
18.22% |
17.92% |
| Chunks |
226 |
226 |
| Assets |
249 |
249 |
| Modules |
2914 |
2914 |
| Duplicate Modules |
149 |
149 |
| Duplicate Code |
1.8% |
1.8% |
| Packages |
96 |
96 |
| Duplicate Packages |
2 |
2 |
Bundle size by type 1 change 
1 regression
| Current #2249 |
Baseline #2248 |
|
|---|---|---|
| JS |
9.05MiB (~+0.01%) |
9.05MiB |
| CSS |
863.17KiB |
863.17KiB |
| Fonts |
526.1KiB |
526.1KiB |
| Media |
295.6KiB |
295.6KiB |
| IMG |
140.74KiB |
140.74KiB |
| HTML |
1.36KiB |
1.36KiB |
| Other |
871B |
871B |
Bundle analysis report Branch mherwege:blockly_persistence Project dashboard
Generated by RelativeCI Documentation Report issue
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
florian-h05
approved these changes
Sep 12, 2024
florian-h05
changed the title
|
@mherwege Has this been updated in the docs? |
|
I don‘t think these minor changes (basically add shadow blocks where they were missing) needs a doc update. Do you agree? |
|
@stefan-hoehn @florian-h05 I agree I don't think this needs further documentation. The purpose of this was to make things clearer when building Blockly rules, so it does not need all the documentation. |
|
Agreed. It would be just nice if the pics would be updated but I myself refrain from doing so often as it is not worth the effort. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When going through the available blocks, I saw potential for a few small improvements, which I collected in this PR:
previous...Stateandnext...Stateblocks: add boolean shadow block for skip same, default falsetimerblocks: add aundefinedshadow block forcontext.run rule or scriptblock: make the parameter dictionnary input a shadow blockThe above does not change functionality, but I find it cleaner to always a default attached to the input, even if it is not required for the code. It avoids users thinking they need to put something in. Having a default indicates the default will work unless they need something specific.
In addition to that, for the
transformblock, I made the transformation dropdown dependent on the installed transformations.