[BasicUI] Fix character encoding of returned page

[lolodomo]

Fix #2681

Concerns only the settings page and the page listing all sitemaps

Signed-off-by: Laurent Garnier lg.hc@free.fr

[wborn]

Nice to see it fixed. 👍
Maybe also update the ManifestServlet similarly?

[lolodomo]

Maybe also update the ManifestServlet similarly?

Oh yes

[lolodomo]

Done

[wborn]

LGTM! Might also be an idea to check other add-ons for similar issues.

[lolodomo]

For the full explanation, res.setContentType with text/html;charset=UTF-8 as parameter is also setting the character encoding which is then considered when calling res.getWriter().
An alternative is to call res.setCharacterEncoding.
Whenres.setContentType was not first called, res.getWriter() was considering the default charset "iso-8859-1".

[dilyanpalauzov]

Where does charset=ISO-8959-1/Latin-1 come from? Can that place be enforced to send UTF-8 instead? Then there will be no need to set explicitly UTF-8 on many places.

[lolodomo]

After the merge, I will cherry-pick this fix in 4.2.x.

[lolodomo]

Where does charset=ISO-8959-1/Latin-1 come from? Can that place be enforced to send UTF-8 instead? Then there will be no need to set explicitly UTF-8 on many places.

I just explained it in my previous message.
It is the behaviour defined by javax.servlet.ServletResponse

[dilyanpalauzov]

After the merge, I will cherry-pick this fix in 4.2.x.

I do not know where is discussed what to backport, but I propose also openhab/openhab-core#4312 for including in 4.2.x.

[florian-h05]

I do not know where is discussed what to backport, but I propose also openhab/openhab-core#4312 for including in 4.2.x.

This is usually discussed inside the PR, and in case of your linked PR it seems it is already backported.

[lolodomo]

but I propose also openhab/openhab-core#4312 for including in 4.2.x.

It was back-ported and should be available in 4.2.1.

[dilyanpalauzov]

but I propose also openhab/openhab-core#4312 for including in 4.2.x.

It was back-ported and should be available in 4.2.1.

Ah, it is in https://github.com/kaikreuzer/openhab-core/commits/4.2.x/ . I have not found it at https://github.com/openhab/openhab-core/commits/4.2.x/ .

[lolodomo]

You just have it included in the release notes of 4.2.1:
https://github.com/openhab/openhab-distro/releases/tag/4.2.1

[lolodomo]

Might also be an idea to check other add-ons for similar issues.

I have done a quick check in addons repository (30 files) and most of the time a character encoding is set before calling response.getWriter(). It can happen it is not set before but maybe the developer knows in that case that iso-8859-1 is an appropriate default character encoding ? I see it not set especially in the cases of XML or JSON responses.

[wborn]

Ah, it is in https://github.com/kaikreuzer/openhab-core/commits/4.2.x/ . I have not found it at https://github.com/openhab/openhab-core/commits/4.2.x/ .

Thanks for noticing!
Looks like several others were missing too so I've cherry-picked those as well and removed them from the release notes.

[lolodomo]

@kaikreuzer : any chance that you review this small PR fixing an annoying bug ?

[kaikreuzer]

Sure thing - thanks!

[lsiepel]

After the merge, I will cherry-pick this fix in 4.2.x.

^^

[lolodomo]

Backported to branch 4.2.x.