Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transformation edit: Improve dirty handling & Fix settings styling #2759

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

florian-h05
Copy link
Contributor

Only mark the transformation as dirty if there was an actual change, not only an editor input.

@florian-h05 florian-h05 requested a review from ghys as a code owner September 16, 2024 16:04
@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Sep 16, 2024
@florian-h05 florian-h05 added this to the 4.3 milestone Sep 16, 2024
Copy link

relativeci bot commented Sep 16, 2024

#2267 Bundle Size — 10.82MiB (~+0.01%).

d892f5f(current) vs b7e2efe main#2265(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change
                 Current
#2267
     Baseline
#2265
No change  Initial JS 1.89MiB 1.89MiB
No change  Initial CSS 576.5KiB 576.5KiB
Change  Cache Invalidation 17.69% 19.78%
No change  Chunks 226 226
No change  Assets 249 249
No change  Modules 2920 2920
No change  Duplicate Modules 149 149
No change  Duplicate Code 1.8% 1.8%
No change  Packages 96 96
No change  Duplicate Packages 2 2
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
#2267
     Baseline
#2265
Regression  JS 9.04MiB (~+0.01%) 9.04MiB
Improvement  CSS 863.22KiB (-0.01%) 863.35KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.36KiB 1.36KiB
No change  Other 871B 871B

Bundle analysis reportBranch florian-h05:transformation-dirtyProject dashboard


Generated by RelativeCIDocumentationReport issue

Only mark the transformation as dirty if there was an actual change,
not only an editor input.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 merged commit bd70e6b into openhab:main Sep 16, 2024
8 checks passed
@florian-h05 florian-h05 deleted the transformation-dirty branch September 16, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant