Thing details: Fix config action saves the whole Thing #2775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A Thing config action is only supposed to save the config of the Thing, not the whole Thing. Fixes openhab/openhab-core#4380. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
#2291 Bundle Size — 10.82MiB (~+0.01%).4346b6d(current) vs e742d7a main#2286(baseline) Warning Bundle contains 2 duplicate packages – View duplicate packages Bundle metrics
|
| Current #2291 |
Baseline #2286 |
|
|---|---|---|
 Initial JS |
1.89MiB |
1.89MiB |
| Initial CSS |
576.5KiB |
576.5KiB |
| Cache Invalidation |
18.15% |
18.15% |
| Chunks |
226 |
226 |
| Assets |
249 |
249 |
| Modules |
2920 |
2920 |
| Duplicate Modules |
149 |
149 |
| Duplicate Code |
1.8% |
1.8% |
| Packages |
96 |
96 |
| Duplicate Packages |
2 |
2 |
Bundle size by type 
1 change 
1 regression
| Current #2291 |
Baseline #2286 |
|
|---|---|---|
| JS |
9.04MiB (~+0.01%) |
9.04MiB |
| CSS |
863.22KiB |
863.22KiB |
| Fonts |
526.1KiB |
526.1KiB |
| Media |
295.6KiB |
295.6KiB |
| IMG |
140.74KiB |
140.74KiB |
| HTML |
1.39KiB |
1.39KiB |
| Other |
871B |
871B |
Bundle analysis report Branch florian-h05:thing-configaction-s... Project dashboard
Generated by RelativeCI Documentation Report issue
|
@digitaldan Please let me know if you have tested this fix. |
|
Shall we backport this to 4.2? |
florian-h05
added a commit
that referenced
this pull request
Oct 1, 2024
A Thing config action is only supposed to save the config of the Thing, not the whole Thing. Fixes openhab/openhab-core#4380. Signed-off-by: Florian Hotze <florianh_dev@icloud.com> (cherry picked from commit d78e6d9)
|
Sure, done 👍 |
florian-h05
added
the
patch
florian-h05
added a commit
to florian-h05/openhab-webui
that referenced
this pull request
Oct 1, 2024
Follow-up for openhab#2775. Fixes openhab#2782. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
florian-h05
added a commit
that referenced
this pull request
Oct 1, 2024
florian-h05
added a commit
that referenced
this pull request
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Thing config action is only supposed to save the config of the Thing, not the whole Thing.
Fixes openhab/openhab-core#4380.
Fixes #2782.