-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor card widgets to use a shared base component (oh-card
)
#2781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
florian-h05
force-pushed
the
refactor-oh-card
branch
from
October 1, 2024 11:17
e0644fe
to
fa50d0c
Compare
#2312 Bundle Size — 10.83MiB (+0.01%).437540a(current) vs 4785cfa main#2306(baseline) Warning Bundle contains 2 duplicate packages – View duplicate packages Bundle metrics
|
Current #2312 |
Baseline #2306 |
|
---|---|---|
Initial JS | 1.89MiB (+0.09% ) |
1.89MiB |
Initial CSS | 576.57KiB (-0.01% ) |
576.65KiB |
Cache Invalidation | 24.05% |
17.44% |
Chunks | 226 |
226 |
Assets | 249 |
249 |
Modules | 2917 (-0.14% ) |
2921 |
Duplicate Modules | 149 |
149 |
Duplicate Code | 1.8% |
1.8% |
Packages | 96 |
96 |
Duplicate Packages | 2 |
2 |
Bundle size by type 2 changes
1 regression
1 improvement
Current #2312 |
Baseline #2306 |
|
---|---|---|
JS | 9.04MiB (+0.02% ) |
9.04MiB |
CSS | 863.34KiB (~-0.01% ) |
863.42KiB |
Fonts | 526.1KiB |
526.1KiB |
Media | 295.6KiB |
295.6KiB |
IMG | 140.74KiB |
140.74KiB |
HTML | 1.39KiB |
1.39KiB |
Other | 871B |
871B |
Bundle analysis report Branch florian-h05:refactor-oh-card Project dashboard
Generated by RelativeCI Documentation Report issue
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
florian-h05
force-pushed
the
refactor-oh-card
branch
from
October 1, 2024 12:10
efd547d
to
9143386
Compare
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
As I have now tested all card widgets, I will merge this PR. |
florian-h05
changed the title
Refactor card widgets to use a shared base component
Refactor card widgets to use a new, shared base component
Oct 1, 2024
florian-h05
changed the title
Refactor card widgets to use a new, shared base component
Refactor card widgets to use a shared base component (Oct 1, 2024
oh-card
)
Thanks for the awesome job! <3 Great improvement for styling! |
Awesome! |
florian-h05
added a commit
to florian-h05/openhab-webui
that referenced
this pull request
Oct 3, 2024
Fixes openhab#2793. Regression from openhab#2781. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
florian-h05
added a commit
that referenced
this pull request
Oct 3, 2024
florian-h05
added a commit
to florian-h05/openhab-webui
that referenced
this pull request
Oct 3, 2024
Regression from openhab#2781. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
florian-h05
added a commit
that referenced
this pull request
Oct 3, 2024
Regression from #2781. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
stefan-hoehn
pushed a commit
to stefan-hoehn/openhab-webui
that referenced
this pull request
Oct 5, 2024
) Fixes openhab#2793. Regression from openhab#2781. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
stefan-hoehn
pushed a commit
to stefan-hoehn/openhab-webui
that referenced
this pull request
Oct 5, 2024
Regression from openhab#2781. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
florian-h05
added a commit
that referenced
this pull request
Dec 19, 2024
florian-h05
added a commit
that referenced
this pull request
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #1801.
Implements the great proposal from #1801 (comment):