Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oh-input: Fix style issue on mobile when sendButton enabled & Update docs #2806

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

florian-h05
Copy link
Contributor

This fixes a minor styling issue on mobile devices, where the input's column is too wide and the sendButton overflows to the next line. Also add time to the docs for valid input types.

…te docs

This fixes a minor styling issue on mobile devices,
where the input's column is too wide and the sendButton overflows to the next line.
Also add `time` to the docs for valid input types.

Signed-off-by: Florian Hotze <dev@florianhotze.com>
@florian-h05 florian-h05 requested a review from ghys as a code owner October 11, 2024 21:53
Signed-off-by: Florian Hotze <dev@florianhotze.com>
Copy link

relativeci bot commented Oct 11, 2024

#2379 Bundle Size — 10.84MiB (~+0.01%).

321ef2c(current) vs 83e40d5 main#2377(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#2379
     Baseline
#2377
Regression  Initial JS 1.89MiB(~+0.01%) 1.89MiB
No change  Initial CSS 577.21KiB 577.21KiB
Change  Cache Invalidation 24.09% 23.1%
No change  Chunks 226 226
No change  Assets 249 249
No change  Modules 2919 2919
No change  Duplicate Modules 149 149
No change  Duplicate Code 1.8% 1.8%
No change  Packages 96 96
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#2379
     Baseline
#2377
Regression  JS 9.05MiB (~+0.01%) 9.05MiB
No change  CSS 863.98KiB 863.98KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.38KiB 1.38KiB
No change  Other 871B 871B

Bundle analysis reportBranch florian-h05:oh-input-stylefix-do...Project dashboard


Generated by RelativeCIDocumentationReport issue

@florian-h05 florian-h05 merged commit 0396d31 into openhab:main Oct 11, 2024
8 checks passed
@florian-h05 florian-h05 deleted the oh-input-stylefix-docs branch October 11, 2024 22:19
@florian-h05 florian-h05 added bug Something isn't working main ui Main UI labels Oct 11, 2024
@florian-h05 florian-h05 added this to the 4.3 milestone Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant