Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number parameter: Allow configuring any step size/number of decimals #2832

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

florian-h05
Copy link
Contributor

@florian-h05 florian-h05 commented Oct 25, 2024

By setting step size to 0 in a config description parameter, one can allow any step size i.e. the user can enter as many decimals as he wants to.

…tep to 0

Signed-off-by: Florian Hotze <dev@florianhotze.com>
Copy link

relativeci bot commented Oct 25, 2024

#2415 Bundle Size — 10.84MiB (~+0.01%).

0a3e48a(current) vs 331f794 main#2413(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Improvement 1 improvement
                 Current
#2415
     Baseline
#2413
Improvement  Initial JS 1.9MiB(~-0.01%) 1.9MiB
No change  Initial CSS 577.21KiB 577.21KiB
Change  Cache Invalidation 17.53% 22.69%
No change  Chunks 226 226
No change  Assets 249 249
No change  Modules 2927 2927
No change  Duplicate Modules 151 151
No change  Duplicate Code 1.88% 1.88%
No change  Packages 96 96
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#2415
     Baseline
#2413
Regression  JS 9.06MiB (~+0.01%) 9.06MiB
No change  CSS 864.03KiB 864.03KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.38KiB 1.38KiB
No change  Other 871B 871B

Bundle analysis reportBranch florian-h05:parameter-number-any...Project dashboard


Generated by RelativeCIDocumentationReport issue

@florian-h05 florian-h05 marked this pull request as ready for review October 25, 2024 16:21
@florian-h05 florian-h05 requested a review from ghys as a code owner October 25, 2024 16:21
@florian-h05 florian-h05 changed the title Number parameter: Optionally allow any step size/number of decimals Number parameter: Allow configuring any step size/number of decimals Oct 25, 2024
@florian-h05 florian-h05 merged commit c225819 into openhab:main Oct 25, 2024
8 checks passed
@florian-h05 florian-h05 deleted the parameter-number-anystep branch October 25, 2024 16:24
@florian-h05 florian-h05 added this to the 4.3 milestone Oct 25, 2024
@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Oct 25, 2024
florian-h05 added a commit to florian-h05/openhab-core that referenced this pull request Oct 26, 2024
…tep size

Refs openhab/openhab-webui#2832.

Signed-off-by: Florian Hotze <dev@florianhotze.com>
J-N-K pushed a commit to openhab/openhab-core that referenced this pull request Oct 26, 2024
…tep size (#4425)

Refs openhab/openhab-webui#2832.

Signed-off-by: Florian Hotze <dev@florianhotze.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant