-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BasicUI] Implement new sitemap element Colortemperaturepicker #2851
[BasicUI] Implement new sitemap element Colortemperaturepicker #2851
Conversation
2450372
to
ff1b4c7
Compare
913160a
to
203c218
Compare
Very good idea, I will do that. Edit: it could even replace the button with the icon. The button would contain the current color. |
Conversion from Kelvin to RGB is not done in frontend. Backend is providing 21 RGB values to frontend covering the min/max range (to create the linear gradient). The idea of this "preview" color could also be applied to the Colorpicker widget. |
Good idea! |
I guess there are two sub- cases..
|
When the color is updated from the picker itself, a command is sent to the item. The widget is updated when it receives a feedback state from the item. |
8c29be0
to
4093b0d
Compare
Related to openhab/openhab-core#3891 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
4093b0d
to
7de9493
Compare
@lolodomo The "ok" button in the popup suggests that the value is updated when the button is pressed. But it seems that it's updated as soon as the slider is changed. Maybe rename the button to "close"? |
Yes, same behaviour as for the color picker. I agree that "Close" would be more appropriate in both pop-ups. |
Related to openhab/openhab-core#3891