Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model (picker): Fix toolbar checkbox issues with safe areas #2861

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

florian-h05
Copy link
Contributor

Fixes #2718.

Fixes openhab#2718.

Signed-off-by: Florian Hotze <dev@florianhotze.com>
@florian-h05 florian-h05 requested a review from ghys as a code owner November 5, 2024 19:05
@florian-h05 florian-h05 added bug Something isn't working main ui Main UI labels Nov 5, 2024
@florian-h05 florian-h05 added this to the 4.3 milestone Nov 5, 2024
Copy link

relativeci bot commented Nov 5, 2024

#2462 Bundle Size — 10.86MiB (-0.02%).

e62dccf(current) vs 1612d50 main#2459(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 5 changes Regression 2 regressions
                 Current
#2462
     Baseline
#2459
Regression  Initial JS 1.9MiB(~+0.01%) 1.9MiB
No change  Initial CSS 577.31KiB 577.31KiB
Change  Cache Invalidation 20.01% 17.73%
No change  Chunks 226 226
No change  Assets 249 249
Change  Modules 2939(+0.03%) 2938
Regression  Duplicate Modules 152(+0.66%) 151
Change  Duplicate Code 1.8%(-3.74%) 1.87%
No change  Packages 96 96
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Improvement 1 improvement
                 Current
#2462
     Baseline
#2459
Improvement  JS 9.07MiB (-0.02%) 9.07MiB
No change  CSS 864KiB 864KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.38KiB 1.38KiB
No change  Other 871B 871B

Bundle analysis reportBranch florian-h05:model-checkboxesProject dashboard


Generated by RelativeCIDocumentationReport issue

@florian-h05 florian-h05 merged commit e32700f into openhab:main Nov 5, 2024
8 checks passed
@florian-h05 florian-h05 deleted the model-checkboxes branch November 5, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checkboxes of Semantic Model not shown correctly on iPhone in portrait mode
1 participant