Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix safe-area issues #2910

Merged
merged 3 commits into from
Dec 10, 2024
Merged

Fix safe-area issues #2910

merged 3 commits into from
Dec 10, 2024

Conversation

florian-h05
Copy link
Contributor

@florian-h05 florian-h05 commented Dec 10, 2024

This fixes safe-area issues all over the UI:

  • Issues where the safe area was applied to elements where it should not, e.g. the settings menus' entries.
  • Issues where the safe area was missing, e.g. model cards, which were hidden under the notch.

Due to webpack's CssMinimizerPlugin minimizing 0px to 0 when overriding the Framework7 safe area CSS vars, which then broke the calculation, a new .css file has been introduced.

Signed-off-by: Florian Hotze <dev@florianhotze.com>
Copy link

relativeci bot commented Dec 10, 2024

#2553 Bundle Size — 10.9MiB (~+0.01%).

c0af022(current) vs 1783d8f main#2551(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 4 changes Regression 2 regressions
                 Current
#2553
     Baseline
#2551
Regression  Initial JS 1.92MiB(~+0.01%) 1.92MiB
Regression  Initial CSS 577.83KiB(+0.06%) 577.48KiB
Change  Cache Invalidation 24.3% 17.65%
No change  Chunks 226 226
No change  Assets 249 249
Change  Modules 2947(+0.03%) 2946
No change  Duplicate Modules 152 152
No change  Duplicate Code 1.8% 1.8%
No change  Packages 96 96
No change  Duplicate Packages 2 2
Bundle size by type  Change 2 changes Regression 2 regressions
                 Current
#2553
     Baseline
#2551
Regression  JS 9.11MiB (~+0.01%) 9.11MiB
Regression  CSS 866.71KiB (+0.04%) 866.34KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.38KiB 1.38KiB
No change  Other 871B 871B

Bundle analysis reportBranch florian-h05:safearea-fixesProject dashboard


Generated by RelativeCIDocumentationReport issue

Signed-off-by: Florian Hotze <dev@florianhotze.com>
Signed-off-by: Florian Hotze <dev@florianhotze.com>
@florian-h05 florian-h05 added bug Something isn't working main ui Main UI labels Dec 10, 2024
@florian-h05 florian-h05 added this to the 4.3 milestone Dec 10, 2024
@florian-h05 florian-h05 marked this pull request as ready for review December 10, 2024 19:52
@florian-h05 florian-h05 requested a review from ghys as a code owner December 10, 2024 19:52
@florian-h05 florian-h05 merged commit b611805 into openhab:main Dec 10, 2024
8 checks passed
@florian-h05 florian-h05 deleted the safearea-fixes branch December 10, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant