Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import treeview items locally & Clean-up sitemap page components #2915

Merged
merged 5 commits into from
Dec 22, 2024

Conversation

mherwege
Copy link
Contributor

See #2904 (comment) and #2904 (comment)

This moves the import from the treeview items for model and sitemap out of app.js and removes the sitemap page elements as this was never used.

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Copy link

relativeci bot commented Dec 12, 2024

#2561 Bundle Size — 10.9MiB (-0.02%).

31dd023(current) vs dfd1e45 main#2559(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 5 changes Regression 1 regression Improvement 2 improvements
                 Current
#2561
     Baseline
#2559
Improvement  Initial JS 1.9MiB(-0.89%) 1.92MiB
Improvement  Initial CSS 577.39KiB(-0.08%) 577.83KiB
Change  Cache Invalidation 24.27% 18.31%
No change  Chunks 226 226
No change  Assets 249 249
Change  Modules 2945(-0.07%) 2947
Regression  Duplicate Modules 154(+1.32%) 152
No change  Duplicate Code 1.8% 1.8%
No change  Packages 96 96
No change  Duplicate Packages 2 2
Bundle size by type  Change 2 changes Improvement 2 improvements
                 Current
#2561
     Baseline
#2559
Improvement  JS 9.11MiB (-0.02%) 9.11MiB
Improvement  CSS 866.44KiB (-0.03%) 866.71KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.38KiB 1.38KiB
No change  Other 871B 871B

Bundle analysis reportBranch mherwege:package_cleanupProject dashboard


Generated by RelativeCIDocumentationReport issue

Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Dec 22, 2024
@florian-h05 florian-h05 added this to the 5.0 milestone Dec 22, 2024
@florian-h05 florian-h05 changed the title Package cleanup Import treeview items locally & Clean-up sitemap page view Dec 22, 2024
@florian-h05 florian-h05 changed the title Import treeview items locally & Clean-up sitemap page view Import treeview items locally & Clean-up sitemap page components Dec 22, 2024
@florian-h05 florian-h05 merged commit 8d8e46a into openhab:main Dec 22, 2024
8 checks passed
@mherwege mherwege deleted the package_cleanup branch December 22, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants