Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactive SVG canvas: Add String Type support #2948

Merged
merged 1 commit into from
Dec 28, 2024

Conversation

stefan-hoehn
Copy link
Contributor

Addition to interactive SVG layout:

Adds String type support by allowing to compare a string to a specific value that is perceived as state ON:

Here an example: If the state of the String is "BD/DVD", highlight the button of the receiver:

image image

Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
Copy link

relativeci bot commented Dec 27, 2024

#2599 Bundle Size — 10.9MiB (~+0.01%).

59bb5df(current) vs bd9c6f0 main#2593(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#2599
     Baseline
#2593
Regression  Initial JS 1.9MiB(+0.02%) 1.9MiB
No change  Initial CSS 577.39KiB 577.39KiB
Change  Cache Invalidation 17.42% 18.15%
No change  Chunks 226 226
No change  Assets 249 249
No change  Modules 2947 2947
No change  Duplicate Modules 154 154
No change  Duplicate Code 1.8% 1.8%
No change  Packages 96 96
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#2599
     Baseline
#2593
Regression  JS 9.11MiB (~+0.01%) 9.11MiB
No change  CSS 866.47KiB 866.47KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.38KiB 1.38KiB
No change  Other 871B 871B

Bundle analysis reportBranch stefan-hoehn:int_svg_string_typeProject dashboard


Generated by RelativeCIDocumentationReport issue

Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Dec 28, 2024
@florian-h05 florian-h05 added this to the 5.0 milestone Dec 28, 2024
@florian-h05 florian-h05 merged commit df02810 into openhab:main Dec 28, 2024
6 checks passed
@florian-h05 florian-h05 deleted the int_svg_string_type branch December 28, 2024 10:52
@florian-h05 florian-h05 changed the title Interactive SVG add String Type support Interactive SVG canvas: Add String Type support Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants