Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Inbox approve menu to add Thing of binding page #2973

Merged
merged 1 commit into from
Jan 4, 2025
Merged

Add Inbox approve menu to add Thing of binding page #2973

merged 1 commit into from
Jan 4, 2025

Conversation

florian-h05
Copy link
Contributor

Supersedes #2921.

@florian-h05
Add Inbox approve menu to add Thing of binding page
8833e1d 
Supersedes openhab#2921.

Signed-off-by: Florian Hotze <dev@florianhotze.com>
@florian-h05 florian-h05 requested a review from ghys as a code owner January 4, 2025 15:59
@florian-h05 florian-h05 mentioned this pull request Jan 4, 2025
Closed
@relativeci RelativeCI
Copy link

relativeci bot commented Jan 4, 2025

#2639 Bundle Size — 10.97MiB (~+0.01%).

8833e1d(current) vs f1c3896 main#2638(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes
                 Current
#2639		      Baseline
#2638
No change  Initial JS 1.9MiB 1.9MiB
No change  Initial CSS 577.21KiB 577.21KiB
Change  Cache Invalidation 18.04% 17.33%
No change  Chunks 227 227
No change  Assets 250 250
Change  Modules 2950(+0.03%) 2949
No change  Duplicate Modules 154 154
No change  Duplicate Code 1.78% 1.78%
No change  Packages 98 98
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#2639		      Baseline
#2638
Regression  JS 9.18MiB (~+0.01%) 9.18MiB
No change  CSS 866.3KiB 866.3KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.38KiB 1.38KiB
No change  Other 871B 871B

Bundle analysis report Branch florian-h05:thing-inbox-approve Project dashboard

Generated by RelativeCI Documentation Report issue

@florian-h05 florian-h05 merged commit 6104cba into openhab:main Jan 4, 2025
5 checks passed
@florian-h05 florian-h05 deleted the thing-inbox-approve branch January 4, 2025 16:06
@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Jan 4, 2025
@florian-h05 florian-h05 added this to the 5.0 milestone Jan 4, 2025
@stefan-hoehn
Copy link
Contributor

Looks as follows now

image

and is shown at /things/add/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghys ghys Awaiting requested review from ghys ghys is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@florian-h05 @stefan-hoehn