Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings menu: Always show things count even when inbox is not empty #3001

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Jan 10, 2025

Change from:
image

To:
image

When there is nothing in inbox:
image

Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@jimtng jimtng changed the title Settings menu: Always show things count Settings menu: Always show things count even when inbox is not empty Jan 10, 2025
Copy link

relativeci bot commented Jan 10, 2025

#2677 Bundle Size — 10.98MiB (~+0.01%).

b2bbd70(current) vs f83116f main#2676(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change
                 Current
#2677
     Baseline
#2676
No change  Initial JS 1.9MiB 1.9MiB
No change  Initial CSS 577.21KiB 577.21KiB
Change  Cache Invalidation 17.55% 18.28%
No change  Chunks 227 227
No change  Assets 250 250
No change  Modules 2950 2950
No change  Duplicate Modules 154 154
No change  Duplicate Code 1.8% 1.8%
No change  Packages 98 98
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#2677
     Baseline
#2676
Regression  JS 9.19MiB (~+0.01%) 9.19MiB
No change  CSS 867.02KiB 867.02KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.38KiB 1.38KiB
No change  Other 871B 871B

Bundle analysis reportBranch jimtng:settings-things-countProject dashboard


Generated by RelativeCIDocumentationReport issue

Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@florian-h05 florian-h05 merged commit bd3f1c4 into openhab:main Jan 10, 2025
5 checks passed
@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Jan 10, 2025
@florian-h05 florian-h05 added this to the 5.0 milestone Jan 10, 2025
@jimtng jimtng deleted the settings-things-count branch January 10, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants