Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thing details: Add "Install Binding" button for HANDLER_MISSING_ERROR #3003

Merged
merged 1 commit into from
Jan 12, 2025
Merged

Thing details: Add "Install Binding" button for HANDLER_MISSING_ERROR #3003

merged 1 commit into from
Jan 12, 2025

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Jan 12, 2025

image

Which leads to:

image

@jimtng jimtng force-pushed the thing-install-missing-binding branch from eed61d6 to 8b3d7fd Compare January 12, 2025 01:25
@relativeci RelativeCI
Copy link

relativeci bot commented Jan 12, 2025 •
edited
Loading

#2682 Bundle Size — 10.98MiB (~+0.01%).

8f2d614(current) vs bd3f1c4 main#2678(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Improvement 1 improvement
                 Current
#2682		      Baseline
#2678
Improvement  Initial JS 1.9MiB(~-0.01%) 1.9MiB
No change  Initial CSS 577.21KiB 577.21KiB
Change  Cache Invalidation 18.28% 17.55%
No change  Chunks 227 227
No change  Assets 250 250
No change  Modules 2950 2950
No change  Duplicate Modules 154 154
No change  Duplicate Code 1.8% 1.8%
No change  Packages 98 98
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#2682		      Baseline
#2678
Regression  JS 9.19MiB (~+0.01%) 9.19MiB
No change  CSS 867.02KiB 867.02KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.38KiB 1.38KiB
No change  Other 871B 871B

Bundle analysis report Branch jimtng:thing-install-missing-bin... Project dashboard

Generated by RelativeCI Documentation Report issue

@jimtng jimtng force-pushed the thing-install-missing-binding branch from 7f20d60 to f8c22d1 Compare January 12, 2025 02:10
@jimtng
Thing details: Add "Install Binding" button for HANDLER_MISSING_ERROR
8f2d614 
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@jimtng jimtng force-pushed the thing-install-missing-binding branch from f8c22d1 to 8f2d614 Compare January 12, 2025 02:17
ghys
ghys approved these changes Jan 12, 2025
View reviewed changes
Copy link
Member

@ghys ghys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!
LGTM, thanks!

@ghys ghys merged commit 4b1ef3b into openhab:main Jan 12, 2025
5 checks passed
@ghys ghys added this to the 5.0 milestone Jan 12, 2025
@ghys ghys added main ui Main UI enhancement New feature or request labels Jan 12, 2025
@jimtng jimtng deleted the thing-install-missing-binding branch January 12, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghys ghys ghys approved these changes

@florian-h05 florian-h05 Awaiting requested review from florian-h05 florian-h05 is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jimtng @ghys