Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thing Add: Navigate to the new Thing once added #3014

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Thing Add: Navigate to the new Thing once added #3014

merged 1 commit into from
Jan 14, 2025

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Jan 13, 2025

Resolve #3013

@jimtng
Thing Add: Navigate to the new Thing once added
4927335 
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@jimtng jimtng mentioned this pull request Jan 13, 2025
Closed
@relativeci RelativeCI
Copy link

relativeci bot commented Jan 13, 2025

#2706 Bundle Size — 10.98MiB (~-0.01%).

4927335(current) vs 7ef5b6f main#2698(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change
                 Current
#2706		      Baseline
#2698
No change  Initial JS 1.9MiB 1.9MiB
No change  Initial CSS 577.21KiB 577.21KiB
Change  Cache Invalidation 18.04% 17.51%
No change  Chunks 227 227
No change  Assets 250 250
No change  Modules 2951 2951
No change  Duplicate Modules 154 154
No change  Duplicate Code 1.8% 1.8%
No change  Packages 98 98
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Improvement 1 improvement
                 Current
#2706		      Baseline
#2698
Improvement  JS 9.19MiB (~-0.01%) 9.19MiB
No change  CSS 867.02KiB 867.02KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.38KiB 1.38KiB
No change  Other 871B 871B

Bundle analysis report Branch jimtng:thing-navigate-after-add Project dashboard

Generated by RelativeCI Documentation Report issue

@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Jan 14, 2025
@florian-h05 florian-h05 added this to the 5.0 milestone Jan 14, 2025
florian-h05
florian-h05 approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

florian-h05
florian-h05 approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@florian-h05 florian-h05 merged commit 3a03421 into openhab:main Jan 14, 2025
5 checks passed
@jimtng jimtng deleted the thing-navigate-after-add branch January 14, 2025 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florian-h05 florian-h05 florian-h05 approved these changes

@ghys ghys Awaiting requested review from ghys ghys is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.

Thing Add: Navigate to the new Thing once added
2 participants
@jimtng @florian-h05