[logviewer] Support history #3030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Jackson <chris@cd-jackson.com>
#2734 Bundle Size — 10.98MiB (~+0.01%).2c8d821(current) vs 7dd7f31 main#2733(baseline) Warning Bundle contains 2 duplicate packages – View duplicate packages Bundle metrics
|
| Current #2734 |
Baseline #2733 |
|
|---|---|---|
 Initial JS |
1.9MiB |
1.9MiB |
| Initial CSS |
577.21KiB |
577.21KiB |
 Cache Invalidation |
17.39% |
18.04% |
| Chunks |
227 |
227 |
| Assets |
250 |
250 |
| Modules |
2952 |
2952 |
| Duplicate Modules |
154 |
154 |
| Duplicate Code |
1.8% |
1.8% |
| Packages |
98 |
98 |
| Duplicate Packages |
2 |
2 |
Bundle size by type 1 change 
1 regression
| Current #2734 |
Baseline #2733 |
|
|---|---|---|
| JS |
9.19MiB (~+0.01%) |
9.19MiB |
| CSS |
867.33KiB |
867.33KiB |
| Fonts |
526.1KiB |
526.1KiB |
| Media |
295.6KiB |
295.6KiB |
| IMG |
140.74KiB |
140.74KiB |
| HTML |
1.38KiB |
1.38KiB |
| Other |
871B |
871B |
Bundle analysis report Branch cdjackson:logviewer-history Project dashboard
Generated by RelativeCI Documentation Report issue
florian-h05
added
enhancement
florian-h05
reviewed
Feb 15, 2025
There was a problem hiding this comment.
LGTM, thanks!
@kaikreuzer You were a bit too fast with merging, I would have preferred to merge this myself so I can take a look before merging 😉
|
@florian-h05 Sorry, will leave it in future to you. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the UI side of the enhancements to a) receive historical logs from the OH server, and b) improve performance by receiving arrays of log entries rather than just single entries.
It does work with the existing log system since it will work with both single log entries (as currently used) and arrays of logs. Due to the change in format, the filter requests do log a parse error since it now uses a DTO with a number of bits of data rather than just an array of loggers, but this doesn't impact anything else. Therefore it is safe to merge this before the core is merged (although it's probably best to wait a little to ensure there's no major comments to the core side!).
This also fixes a minor bug where the number of filtered logs may be incorrectly displayed.
With this and the core changes, I can display full zigbee debug - it's about 2000 lines in 15 seconds (or put another way, the log buffer shows about 15 seconds of data). The log remains responsive (I can change the logging levels back). Possibly the log buffer can/should be increased more than 2000 entries, but that's for another day...
Core PR coming soon...