Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link Edit: Add dirty checking #3040

Merged
merged 1 commit into from
Feb 15, 2025
Merged

Link Edit: Add dirty checking #3040

merged 1 commit into from
Feb 15, 2025

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Jan 27, 2025

Resolve #2943

@jimtng
Link Edit: Add dirty checking
347c77a 
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@relativeci RelativeCI
Copy link

relativeci bot commented Jan 27, 2025

#2750 Bundle Size — 10.98MiB (~+0.01%).

347c77a(current) vs 95844d2 main#2743(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change
                 Current
#2750		      Baseline
#2743
No change  Initial JS 1.9MiB 1.9MiB
No change  Initial CSS 577.21KiB 577.21KiB
Change  Cache Invalidation 18.05% 17.51%
No change  Chunks 227 227
No change  Assets 250 250
No change  Modules 2952 2952
No change  Duplicate Modules 154 154
No change  Duplicate Code 1.8% 1.8%
No change  Packages 98 98
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#2750		      Baseline
#2743
Regression  JS 9.19MiB (~+0.01%) 9.19MiB
No change  CSS 867.33KiB 867.33KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.38KiB 1.38KiB
No change  Other 871B 871B

Bundle analysis report Branch jimtng:link-edit-dirty Project dashboard

Generated by RelativeCI Documentation Report issue

@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Jan 27, 2025
florian-h05
florian-h05 approved these changes Feb 15, 2025
View reviewed changes
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for taking care of all the missing dirty checks!

@florian-h05 florian-h05 added this to the 5.0 milestone Feb 15, 2025
@florian-h05 florian-h05 merged commit 66df892 into openhab:main Feb 15, 2025
5 checks passed
@jimtng jimtng deleted the link-edit-dirty branch February 15, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florian-h05 florian-h05 florian-h05 approved these changes

@ghys ghys Awaiting requested review from ghys ghys is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.

Link-add / link-edit needs dirty checking
2 participants
@jimtng @florian-h05