-
-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix oh-icon icon name type in widget def & docs #3043
Conversation
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, good catch, but you modified a generated doc:
<!-- DO NOT REMOVE the following comments -->
<!-- GENERATED props -->
### General
<div class="props">
<PropGroup label="General">
<PropBlock type="BOOLEAN" name="icon" label="Icon">
<PropBlock type="TEXT" name="icon" label="Icon">
...
You want to modify https://github.com/openhab/openhab-webui/blob/main/bundles/org.openhab.ui/web/src/assets/definitions/widgets/system/icon.js instead first (pb to pt), then regenerate the docs with the script described in
https://github.com/openhab/openhab-webui/blob/main/bundles/org.openhab.ui/CONTRIBUTING.md#documentation--resources
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Thanks! Learnt something new :) In the process of running generate.js there were other changes, which I submitted as a separate commit. |
#2770 Bundle Size — 10.98MiB (0%).ab2b8c8(current) vs 95844d2 main#2743(baseline) Warning Bundle contains 2 duplicate packages – View duplicate packages Bundle metrics
Bundle size by type
Bundle analysis report Branch jimtng:icon-doc Project dashboard Generated by RelativeCI Documentation Report issue |
Ughh, it seems that those changes shouldn't be there. I've removed them, so that this PR only contains changes to icon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
No description provided.