-
-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Script edit: Add support for new python add-on & Refactor automation-languages definition #3051
Conversation
jsjames
commented
Feb 2, 2025
- Added support in script-edit.vue for new/imminent graal python binding.
- removed hard-coding of commentChar and pulled from restructured annotation-language.js definition
- cleaned up the annotation-language definition implementation
… format Signed-off-by: Jeff James <jeff@james-online.com>
#2814 Bundle Size — 10.99MiB (~+0.01%).0b9571b(current) vs fe7e939 main#2813(baseline) Warning Bundle contains 2 duplicate packages – View duplicate packages Bundle metrics
|
Current #2814 |
Baseline #2813 |
|
---|---|---|
1.9MiB |
1.9MiB |
|
577.28KiB |
577.28KiB |
|
17.58% |
17.58% |
|
227 |
227 |
|
250 |
250 |
|
2952 |
2952 |
|
154 |
154 |
|
1.8% |
1.8% |
|
98 |
98 |
|
2 |
2 |
Bundle size by type
7 changes
7 regressions
Current #2814 |
Baseline #2813 |
|
---|---|---|
9.2MiB (+100% ) |
undefined |
|
867.4KiB (+100% ) |
undefined |
|
526.1KiB (+100% ) |
undefined |
|
295.6KiB (+100% ) |
undefined |
|
140.74KiB (+100% ) |
undefined |
|
1.38KiB (+100% ) |
undefined |
|
871B (+100% ) |
undefined |
Bundle analysis report Branch jsjames:annotation_language Project dashboard
Generated by RelativeCI Documentation Report issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is more of a question from myself as an inexperienced javascript coder rather than a request for change
bundles/org.openhab.ui/web/src/pages/settings/rules/script/script-edit.vue
Outdated
Show resolved
Hide resolved
600157d
to
39877d6
Compare
Signed-off-by: Jeff James <jeff@james-online.com>
39877d6
to
fa60e7f
Compare
Signed-off-by: Florian Hotze <dev@florianhotze.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
I have reverted the package-lock.json changes.