Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script edit: Add support for new python add-on & Refactor automation-languages definition #3051

Merged
merged 3 commits into from
Feb 16, 2025

Conversation

jsjames
Copy link
Contributor

@jsjames jsjames commented Feb 2, 2025

  • Added support in script-edit.vue for new/imminent graal python binding.
  • removed hard-coding of commentChar and pulled from restructured annotation-language.js definition
  • cleaned up the annotation-language definition implementation

… format

Signed-off-by: Jeff James <jeff@james-online.com>
Copy link

relativeci bot commented Feb 2, 2025

#2814 Bundle Size — 10.99MiB (~+0.01%).

0b9571b(current) vs fe7e939 main#2813(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  no changes
                 Current
#2814
     Baseline
#2813
No change  Initial JS 1.9MiB 1.9MiB
No change  Initial CSS 577.28KiB 577.28KiB
No change  Cache Invalidation 17.58% 17.58%
No change  Chunks 227 227
No change  Assets 250 250
No change  Modules 2952 2952
No change  Duplicate Modules 154 154
No change  Duplicate Code 1.8% 1.8%
No change  Packages 98 98
No change  Duplicate Packages 2 2
Bundle size by type  Change 7 changes Regression 7 regressions
                 Current
#2814
     Baseline
#2813
Regression  JS 9.2MiB (+100%) undefined
Regression  CSS 867.4KiB (+100%) undefined
Regression  Fonts 526.1KiB (+100%) undefined
Regression  Media 295.6KiB (+100%) undefined
Regression  IMG 140.74KiB (+100%) undefined
Regression  HTML 1.38KiB (+100%) undefined
Regression  Other 871B (+100%) undefined

Bundle analysis reportBranch jsjames:annotation_languageProject dashboard


Generated by RelativeCIDocumentationReport issue

@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Feb 3, 2025
Copy link
Contributor

@jimtng jimtng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is more of a question from myself as an inexperienced javascript coder rather than a request for change

@jsjames jsjames force-pushed the annotation_language branch 2 times, most recently from 600157d to 39877d6 Compare February 3, 2025 14:43
Signed-off-by: Jeff James <jeff@james-online.com>
@jsjames jsjames force-pushed the annotation_language branch from 39877d6 to fa60e7f Compare February 3, 2025 19:11
Signed-off-by: Florian Hotze <dev@florianhotze.com>
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
I have reverted the package-lock.json changes.

@florian-h05 florian-h05 added this to the 5.0 milestone Feb 16, 2025
@florian-h05 florian-h05 changed the title Added support for new python binding, cleaned up annotation-languages… Script edit: Add support for new python add-on & Refactor automation-languages definition Feb 16, 2025
@florian-h05 florian-h05 merged commit 792ff7f into openhab:main Feb 16, 2025
5 checks passed
@jsjames jsjames deleted the annotation_language branch February 19, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants