Sitemap editor: fix negative number parameters

[mherwege]

See: https://community.openhab.org/t/basic-ui-setpoint-negative-values/161011

Parameters with negative number where not parsed correctly. This is because hyphen is defined as a token and therefore already recognized before recognizing the number. Changing the order does not help as it breaks chart period parsing.

This fix avoids recognizing numbers as tokens and handles numbers in the lexer.

Tests where added and all existing tests still pass.

[relativeci]

#2784 Bundle Size — 10.98MiB (+0.01%).

49f3338(current) vs 95844d2 main#2743(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  no changes

	Current #2784	Baseline #2743
Initial JS	1.9MiB	1.9MiB
Initial CSS	577.21KiB	577.21KiB
Cache Invalidation	17.51%	17.51%
Chunks	227	227
Assets	250	250
Modules	2952	2952
Duplicate Modules	154	154
Duplicate Code	1.8%	1.8%
Packages	98	98
Duplicate Packages	2	2

Bundle size by type   7 changes 7 regressions

	Current #2784	Baseline #2743
JS	9.19MiB (+100%)	undefined
CSS	867.33KiB (+100%)	undefined
Fonts	526.1KiB (+100%)	undefined
Media	295.6KiB (+100%)	undefined
IMG	140.74KiB (+100%)	undefined
HTML	1.38KiB (+100%)	undefined
Other	871B (+100%)	undefined

Bundle analysis report Branch mherwege:sitemap_number_param Project dashboard

---

^{Generated by RelativeCI Documentation Report issue}

[jimtng]

Would this work on browsers with a locale that uses a comma as the decimal point?

[mherwege]

@jimtng

Would this work on browsers with a locale that uses a comma as the decimal point?

This is about the sitemap editor and how it parses sitemap xtext syntax, not about displayed values. So, this is not impacted by locale.
The parser first tokenizes and splits on tokens for efficiency. The nearly code was too aggressive at that. I took care to exactly match what is done in the core sitemap parser.

I assume you had our other discussion about input fields and uom in mind.

[jimtng]

Oh good point, it just needs to be the same number syntax that core will use to parse the sitemap. I assume core will require a dot, regardless of its locale?

[mherwege]

Oh good point, it just needs to be the same number syntax that core will use to parse the sitemap. I assume core will require a dot, regardless of its locale?

Yes, it does. the sitemap syntax does not depend on locale.

[florian-h05]

LGTM, thanks!