Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjusted schedule ui to use the new rest service for rule preview #815

Merged
merged 3 commits into from
Apr 11, 2021
Merged

Adjusted schedule ui to use the new rest service for rule preview #815

merged 3 commits into from
Apr 11, 2021

Conversation

soenkekueper
Copy link
Contributor

@soenkekueper soenkekueper commented Jan 17, 2021 •
edited
Loading

@soenkekueper soenkekueper requested a review from a team as a code owner January 17, 2021 13:33
@soenkekueper soenkekueper mentioned this pull request Jan 17, 2021
Merged
Base automatically changed from master to main January 18, 2021 20:05
@ghys ghys mentioned this pull request Feb 10, 2021
Closed
@ghys ghys added the rebuild trigger a new Jenkins job label Feb 10, 2021
@soenkekueper
Adjusted schedule ui to use the new rest service provided to get the …
052229a 
…expected rule executions instead of generating them

Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
@soenkekueper soenkekueper force-pushed the 2044-ScheduleWithConditions branch from f034864 to 052229a Compare April 2, 2021 15:32
@soenkekueper
Fixed ESLint
e849ff6 
Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
@relativeci
Copy link

relativeci bot commented Apr 2, 2021 •
edited
Loading

Job #66: Bundle Size — 10.45MB (-4.4%).

06e8fe6 vs 3e8dccc

Changed metrics (6/8)
Metric Current Baseline
Initial JS 1.61MB(-0.14%) 1.61MB
Cache Invalidation 60.46% 3.13%
Modules 1442(-10.38%) 1609
Chunks 215(-0.46%) 216
Assets 254(-0.39%) 255
Packages 128(-2.29%) 131
Changed assets by type (1/7)
            Current     Baseline
JS 8.12MB (-5.59%) 8.6MB

View Job #66 report on app.relative-ci.com

@soenkekueper
openhab#2044: Adjusted rest endpoint.
2643e2c 
Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
@cweitkamp
Copy link
Contributor

Ready for review. openhab/openhab-core#2125 has been merged.

ghys
ghys approved these changes Apr 11, 2021
View reviewed changes
Copy link
Member

@ghys ghys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works great! And shaves off half a MB of client-side dependencies to compute the cron occurences in the process.

Awesome addition, @soenkekueper!

@ghys ghys merged commit 93d9dd3 into openhab:main Apr 11, 2021
@ghys ghys mentioned this pull request Apr 11, 2021
Closed
@soenkekueper soenkekueper deleted the 2044-ScheduleWithConditions branch April 12, 2021 15:47
@ghys ghys mentioned this pull request Jun 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghys ghys ghys approved these changes

Assignees
No one assigned
Labels
rebuild trigger a new Jenkins job
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ephemeris conditions not evaluated for schedule
3 participants
@soenkekueper @cweitkamp @ghys