Modelview deletekey functionality #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigbasec
force-pushed
the
modelview_deletekey
branch
from
c654c16 to
f5b0a63
Compare
|
Since the delete logic is already in |
|
100% first time ever doing anything w/ F7 or Vue, so little bit of a learning curve here, appologies. I'll take a look at that though and see what I can come up with. And yes, this was literally a copy/paste from there and changing it to match the vue. |
Signed-off-by: Brian Homeyer <bhomeyer@gmail.com>
Signed-off-by: Brian Homeyer <bhomeyer@gmail.com>
This reverts commit f5b0a63. Signed-off-by: Brian Homeyer <bhomeyer@gmail.com>
This reverts commit a5e4328. Signed-off-by: Brian Homeyer <bhomeyer@gmail.com>
Move changes to item-detail view Signed-off-by: Brian Homeyer <bhomeyer@gmail.com>
bigbasec
force-pushed
the
modelview_deletekey
branch
from
8b7f81f to
555dd16
Compare
|
@ghys Should be all set now. Thanks |
ghys
pushed a commit
that referenced
this pull request
Apr 18, 2021
Signed-off-by: Brian Homeyer <bhomeyer@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I was testing my OH setup I found myself always winding up with orphan items in the model view, and clicking to remove them was a bit of a hassle, so I came up with this.
Might be a better way to do this, just really copied the code from the detail view and refactored for the main page.