Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes the item clickable in the Channel/Item link view #841

Merged
merged 1 commit into from
Jan 24, 2021

Conversation

bigbasec
Copy link
Contributor

Makes the item in the channel/link page clickable and go to the item in question.

Resolves issue : #760

@bigbasec bigbasec requested a review from a team as a code owner January 24, 2021 03:40
@ghys
Copy link
Member

ghys commented Jan 24, 2021

Thanks, my main concern is that it creates a flow with more than 2 pages when going to thing > link details > item details or model > link details > item details.
Only the previous page is kept hidden behind the current one, so with these flows when going to the item details the original page will get destroyed, and therefore loses its state when coming back. That was the main reason why there were no links on these pages.
But let's revisit this and try it anyway.

@ghys ghys merged commit f85635d into openhab:main Jan 24, 2021
@bigbasec
Copy link
Contributor Author

@ghys Would just changing it to a href work better? I know that would break the flow a bit, but it might be a better way to do it.

I was also considering making a popup for that and just showing the item details, so that's also on the table too. I see the need, though not sure the best way to solve it. This was honestly the least effort for something I didn't know if it was going to fly anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants