Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to save service configuration with Ctrl-S on the keyboard #867

Merged
merged 1 commit into from
Jan 31, 2021

Conversation

bigbasec
Copy link
Contributor

Very simply adds the control-S to the page to make it more in line with some of the other pages.

@bigbasec bigbasec requested a review from a team as a code owner January 30, 2021 17:24
Signed-off-by: Brian Homeyer <bhomeyer@gmail.com>
Copy link
Member

@ghys ghys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now ;)
Thanks for your effort, looking forward to the Blockly improvements!

@ghys ghys merged commit 4271845 into openhab:main Jan 31, 2021
@ghys ghys changed the title Add control-s to settings page Add ability to save service configuration with Ctrl-S on the keyboard Jan 31, 2021
@ghys ghys added enhancement New feature or request main ui Main UI labels Jan 31, 2021
@ghys ghys added this to the 3.1 milestone Jan 31, 2021
@bigbasec bigbasec deleted the add_save_to_settings branch January 31, 2021 16:15
ghys pushed a commit that referenced this pull request Feb 7, 2021
```
vue.esm.js?a026:628 [Vue warn]: Property or method "onPageAfterIn" is not defined on the instance but referenced during render. Make sure that this property is reactive, either in the data option, or for class-based components, by initializing the property. See: https://vuejs.org/v2/guide/reactivity.html#Declaring-Reactive-Properties.
```

Introduced by #867.

Signed-off-by: Boris Krivonog <boris.krivonog@inova.si>
ghys pushed a commit that referenced this pull request Apr 18, 2021
ghys pushed a commit that referenced this pull request Apr 18, 2021
```
vue.esm.js?a026:628 [Vue warn]: Property or method "onPageAfterIn" is not defined on the instance but referenced during render. Make sure that this property is reactive, either in the data option, or for class-based components, by initializing the property. See: https://vuejs.org/v2/guide/reactivity.html#Declaring-Reactive-Properties.
```

Introduced by #867.

Signed-off-by: Boris Krivonog <boris.krivonog@inova.si>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants