Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing link to f7 input docs #917

Merged
merged 1 commit into from
Feb 22, 2021
Merged

Add missing link to f7 input docs #917

merged 1 commit into from
Feb 22, 2021

Conversation

eikowagenknecht
Copy link
Contributor

The link was missing. Not much more to say about this one.

Also aligned the style of those two links that are just next to each other to look the same.

This is what it looks like:

image

This is what it links to: https://framework7.io/docs/inputs.html#supported-inputs

Signed-off-by: Eiko Wagenknecht eiko.wagenknecht@web.de

Signed-off-by: Eiko Wagenknecht <eiko.wagenknecht@web.de>
@eikowagenknecht eikowagenknecht requested a review from a team as a code owner February 19, 2021 15:05
Copy link
Member

@ghys ghys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Note that the framework7 docs links should be updated to https://v5.framework7.io but for the time being I'll allow it for consistency's sake, and because the API is AFAIK still the same.
There should/will probably be a PR updating all these links in bulk at some point.

@ghys ghys merged commit 8e0b392 into openhab:main Feb 22, 2021
@ghys ghys added enhancement New feature or request main ui Main UI labels Feb 22, 2021
@ghys ghys added this to the 3.1 milestone Feb 22, 2021
@ghys ghys mentioned this pull request Mar 25, 2021
@eikowagenknecht eikowagenknecht deleted the pull-input branch April 25, 2021 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants